Skip to content

[rush-cli-client] Add opt-in invocation telemetry - #6165

Merged
Sean Larkin (TheLarkInn) merged 5 commits into
mainfrom
user/selarkin/rush-client-invocation-telemetry
Oct 27, 2026
Merged

Sean Larkin (TheLarkInn) merged 5 commits into
mainfrom
user/selarkin/rush-client-invocation-telemetry

Conversation

@TheLarkInn

Copy link
Copy Markdown
Member

Summary

Before: clients lose launcher/fallback attribution and full attempt timing.
After: an opt-in repository reporter gets durable, correlated attempts, real integer client-return timing, and the original session/hardware cohort. Delivery is nonblocking and cannot replace the command exit code.

Details

  • No raw arguments or user labels in receipts. Raw cwd is not persisted; optional cwdHash is original-cwd, local-only recovery context and must not be uploaded.
  • Intentional native routing is not fallback.
  • The existing fingerprint-exempt RUSHD_TELEMETRY_TAG carries request context.
  • Malformed optional reporter status warns without disabling configured telemetry.
  • README contract and minor Rush change file; no manual version bump.

How it was tested

Approved snapshot clients in native mode: build passed; focused telemetry tests 12/12; full package suite 659/659 across 51 suites; Rush change verification passed. Telemetry uploads disabled, private RUSH_GLOBAL_FOLDER, and RUSH_PREVIEW_VERSION unset.

Record opt-in, correlated launcher and fallback attempts with durable
receipts, real client-return timing, and repository-controlled reporting.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2fdae5a5-bbb9-4f39-a3e0-c0d21203e97a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2fdae5a5-bbb9-4f39-a3e0-c0d21203e97a
Keep optional reporter-status parse failures nonfatal and capture the
normalized original cwd hash for local-only receipt recovery checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2fdae5a5-bbb9-4f39-a3e0-c0d21203e97a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2fdae5a5-bbb9-4f39-a3e0-c0d21203e97a
Use one caller-provided environment for telemetry suppression, attribution,
delivery, receipt publication and reporter subprocesses. Keep native process
setup at the launcher boundary and preserve process.env as the default.

Add regression coverage for contradictory ambient values, missing override
values, late opt-out and independent instances.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2fdae5a5-bbb9-4f39-a3e0-c0d21203e97a
@TheLarkInn
Sean Larkin (TheLarkInn) enabled auto-merge (squash) October 27, 2026 22:41
@TheLarkInn
Sean Larkin (TheLarkInn) merged commit e5360c7 into main Oct 27, 2026
15 of 16 checks passed
@TheLarkInn
Sean Larkin (TheLarkInn) deleted the user/selarkin/rush-client-invocation-telemetry branch October 27, 2026 22:58
@github-project-automation github-project-automation Bot moved this from Needs triage to Closed in Bug Triage Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants