Repository navigation
[webpack5-module-minifier-plugin] Inline short license comments - #6167
Merged
Ian Clanton-Thuon (iclanton) merged 2 commits intoOct 26, 2026
Merged
Conversation
Add an opt-in inlineShortLicenses option that compares complete deduplicated notices with the reference banner in UTF-8 bytes before emitting a companion asset. Keep equal-size and larger notices external. Preserve license banners for chunks containing only inlined modules, and bump the code-generation revision to invalidate affected hashes. Cover defaults, byte boundaries, Unicode, async chunks, source maps and module positions with real webpack builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use explicit inline/external branches with a single return path, and format inlineShortLicenses as code in the change log. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ian Clanton-Thuon (iclanton)
enabled auto-merge (squash)
October 26, 2026 21:14
David Michon (dmichon-msft)
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A JavaScript chunk's license-reference banner can be larger than the complete license text it points to. Add an opt-in
inlineShortLicensesoption toModuleMinifierPluginso short notices can stay in the JavaScript without emitting a companion.LICENSE.txtasset.Details
false, retaining the existing external-license policy.emitAsset, rather than emitting a license asset and removing it in a later processing pass.How it was tested
node common/scripts/install-run-rush.js build --to @rushstack/webpack5-module-minifier-pluginnode common/scripts/install-run-rush.js test --to @rushstack/webpack5-module-minifier-plugin