Repository navigation
[rush] Scope integration budgets to graph and reporter lifecycle tests - #6183
Merged
Ian Clanton-Thuon (iclanton) merged 1 commit intoOct 30, 2026
Conversation
Give real graph initialization and command/telemetry finalization a 30-second test and hook budget. Preserve cancellation joins, explicit per-case deadlines, all assertions, and production admission/startup timeouts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ian Clanton-Thuon (iclanton)
requested review from
Apostolis Haitalis (apostolisms) and
Pete Gonzalez (octogonz)
as code owners
October 30, 2026 05:46
Ian Clanton-Thuon (iclanton)
requested review from
Bharat Middha (bmiddha),
David Michon (dmichon-msft) and
Jonathon Anthony (jxanthony)
as code owners
October 30, 2026 05:46
Ian Clanton-Thuon (iclanton)
enabled auto-merge (squash)
October 30, 2026 05:47
Bharat Middha (bmiddha)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up #6174 by scoping a 30-second Jest test/hook budget to two other real-process integration files: daemon graph request routing and Rush command reporter lifecycle.
The CI audit found a five-second graph setup hook timeout in run 40634107043 and five-second delayed-telemetry test/teardown timeouts in run 40634446358.
Details
Graph initialization launches Git and build processes in
beforeEach. Reporter lifecycle tests run real commands and join watch/finalization resources inafterEach. These should not inherit the five-second default intended for smaller tests.Only the two integration files change. Explicit per-test deadlines, cancellation/abort handling, resource joins, assertions, production admission/startup timeouts, and global CI concurrency remain unchanged. No retries or skips are added.
This does not fix protocol ordering, filesystem identity, or daemon fixture directory-removal races. The delayed-pong race already has #6153; project-local test workspace cleanup is being prepared separately.
How it was tested
macOS, Node 24.22.2:
libraries/rush-lib,rushx _phase:build— passed (TypeScript, lint, API Extractor, bundle).libraries/rush-lib,rushx _phase:test --test-path-pattern RushCommandLineParserReporterLifecycle— passed, 18 tests.libraries/rush-daemon,rushx _phase:build— passed (TypeScript, lint, API Extractor).libraries/rush-daemon,HOME="$PWD/temp/test-home" node ../../apps/heft/lib-commonjs/start.js run --only test -- --test-path-pattern 'DaemonGraphRequestRouter|DaemonGraphFixtureSetup|WorkspaceRequestAdmission'— passed, 38 tests, including graph setup cancellation/disposal and controlled-clock admission tests. The project-local test home avoids the developer's Rush user.env; an initial run with the normal home correctly rejected engine execution because of that unrelated configuration.node common/scripts/install-run-rush.js change --verify --target-branch microsoft/main --no-fetch— passed.The existing
_phase:testRushx wrapper does not preserve a shell pipe in a regex argument, so the combined selector is passed directly to Heft. Windows and the full repository matrix were not run locally for this PR; CI must validate those.Impacted documentation
None; test-only changes, recorded with no-release change files.