Repository navigation
fix(security): block Brotli decoding in vendored toolkit - #279
Open
Dima Birenbaum (DimaBir) wants to merge 1 commit into
Open
Dima Birenbaum (DimaBir) wants to merge 1 commit into
Dima Birenbaum (DimaBir) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Toolkit PR #24 mitigates the Node.js Brotli decoder path for CVE-2026-111497, but this action still executes an older checked-in toolkit copy. Merging the upstream TypeScript alone does not update those runtime bytes.
What
How
Port the behavior merged as
433e1090696fec074f5fe066e209ece22a50102c, preserving the existing proxy resolver and both download/metadata proxy call sites. Use native dynamic import because the ESM decompressor cannot be loaded with require on older Node 20. All production code outsiderequestJsonis unchanged.Package versions, lockfiles, action lifecycle/runtime metadata and the separate runtime-guard PR #277 are unchanged. No npm publication or release-ref movement is included. A future toolkit reinstall/bump must retain both the mitigation and the existing proxy fix.
Tests