Repository navigation
CI: Run typescript tests - #131
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with adding TypeScript tests to the push and pull-request CI workflows.
No open issues 🎉
What changed in this PR
Adds TypeScript tests to pull-request and push CI checks, helping catch test failures automatically.
Changes:
- Adds a
Teststep after the build in both workflows, runningnpm testfrom thetypescriptdirectory.
| File | Description |
|---|---|
.github/workflows/push-check.yml |
Runs TypeScript tests after the build on pushes. |
.github/workflows/pr-check.yml |
Runs TypeScript tests after the build on pull requests. |
Review effort: Balanced
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
744ce58
into
main
This pull request adds a step to run the test suite as part of the CI workflows for both pull requests and pushes. This ensures that tests are automatically executed after the build process in the
typescriptdirectory, helping catch issues earlier in the development process.CI workflow improvements:
Teststep after theBuildstep in thepr-check.ymlworkflow to runnpm testin thetypescriptdirectory.Teststep after theBuildstep in thepush-check.ymlworkflow to runnpm testin thetypescriptdirectory.