Skip to content

CI: Run typescript tests - #131

Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
ci-run-tests
Nov 11, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
ci-run-tests

Conversation

@edvilme

Copy link
Copy Markdown
Contributor

This pull request adds a step to run the test suite as part of the CI workflows for both pull requests and pushes. This ensures that tests are automatically executed after the build process in the typescript directory, helping catch issues earlier in the development process.

CI workflow improvements:

  • Added a Test step after the Build step in the pr-check.yml workflow to run npm test in the typescript directory.
  • Added a Test step after the Build step in the push-check.yml workflow to run npm test in the typescript directory.

@edvilme Eduardo Villalpando Mello (edvilme) added the debt Code Cleanup, Refactorings and Repo health. Not feature related label Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with adding TypeScript tests to the push and pull-request CI workflows.

No open issues 🎉

What changed in this PR

Adds TypeScript tests to pull-request and push CI checks, helping catch test failures automatically.

Changes:

  • Adds a Test step after the build in both workflows, running npm test from the typescript directory.
File Description
.github/​workflows/​push-check.yml Runs TypeScript tests after the build on pushes.
.github/​workflows/​pr-check.yml Runs TypeScript tests after the build on pull requests.

Review effort: Balanced

@rchiodo

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@rchiodo

Copy link
Copy Markdown
Contributor

Reviewed commit: d1740e4da003f7479467bbf9a8a24d325700cf4e

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running.

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 11, 2026
@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 744ce58 into main Nov 11, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code Cleanup, Refactorings and Repo health. Not feature related review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants