Repository navigation
Fix error when dismissing PR notifications - #9017
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open findings
Stringare often nullable unless explicitly non-null… · Newauthorobject only setslogin, butCommitEvent.authoris typically treated like… · New{}toGitHubRepositorymakes these tests fragile:parseAccount/parseActorcan read… · New{}toGitHubRepositorymakes these tests fragile:parseAccount/parseActorcan read… · New
What changed in this PR
Fixes crashes when parsing PR timeline data where GitHub returns missing author/committer information for commits or missing merge refs for merged events.
Changes:
- Make commit parsing tolerate
author/committerbeingnull. - Make merge parsing tolerate deleted
mergeRefby falling back tomergeRefName. - Add regression tests for these null/missing-field scenarios.
| File | Description |
|---|---|
| src/test/github/utils.test.ts | Adds tests covering null commit author/committer and deleted merge refs. |
| src/github/utils.ts | Adds null-safe parsing for commit author/committer and merge ref name fallback. |
| src/github/queriesShared.gql | Fetches mergeRefName so merges can be represented even if mergeRef is deleted. |
| src/github/graphql.ts | Updates GraphQL types to allow null for actor/mergeRef/author/committer fields. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ross Wollman (rwoll)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.