[Hardik K (hardikkaurani)]

Summary

Fixes #1583.

Previously, setupRegistryAutoRun in cmdStartup.ts invoked reg add ... /f with only our batch file call string (if exist "mainBatchFile" call "mainBatchFile"), which completely overwrote any existing user or third-party configurations in HKCU\Software\Microsoft\Command Processor\AutoRun. Additionally, removeCmdStartup deliberately did not clean up the AutoRun registry key, leaving orphaned entries upon extension disable/uninstall.

This change:

• Chains rather than overwrites: When existing AutoRun configuration is present, appends our startup call using standard CMD & delimiter (${existing} & ${ourCommand}).
• Ensures idempotency: If our startup call (or its %USERPROFILE% variant) is already present in AutoRun, leaves the configuration untouched without duplicate entries.
• Surgically removes on teardown: During teardownScripts, parses the AutoRun command chain and removes only our segment, restoring any prior user commands. If our command was the sole entry, deletes the AutoRun registry value to restore pre-installation state.
• Adds regression tests: Comprehensive unit test suite covering string tokenization with quotes, merge behavior, idempotency, and surgical removal across all placement scenarios (start, middle, end, sole).

Validation

• npm run compile-tests (0 errors)
• npm run compile (webpack bundled cleanly)
• npm run lint (0 lint issues)
• mocha out/test/features/terminal/shells/cmd/cmdStartup.unit.test.js (22/22 passing)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Hardik K (hardikkaurani)]

Hi Eduardo Villalpando Mello (@edvilme),

Opening this PR to resolve #1583.

It replaces the registry overwrite in setupRegistryAutoRun with non-destructive & command chaining, keeps setup idempotent, and surgically removes only our startup call during teardown (restoring any pre-existing user commands or deleting the key if ours was the only entry).

All pure string transformations are covered by unit tests.

Whenever you have a moment, I'd appreciate your review and feedback. Thank you!