Skip to content

Apply loc patch - #6580

Merged
JohnMcPMS merged 1 commit into
microsoft:masterfrom
JohnMcPMS:loc-update
Oct 7, 2026
Merged

JohnMcPMS merged 1 commit into
microsoft:masterfrom
JohnMcPMS:loc-update

Conversation

@JohnMcPMS

@JohnMcPMS JohnMcPMS commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

📖 Description

Apply loc patch for recent changes.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS
JohnMcPMS requested a review from a team as a code owner October 7, 2026 16:13

@ranm-msft ranm-msft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff. This is an additions-only localization drop: 320 added lines, 0 deletions, across the 10 Localization/Resources/<locale>/winget.resw files, with no code or project changes.

Checked for the things that usually go wrong in a loc patch and found none:

  • All 10 locales received the same 8 keys (PackageSelectionTitle, NumberedSelectionPrompt, NumberedSelectionInvalid, PackageSelectionSelected, PackageSelectionRefine, PackageSelectionRefineForExport, WINGET_CONFIG_ERROR_PROCESSOR_PATH_CHANGED, OutputLocaleArgumentDescription) - 32 lines each, so no locale was dropped or double-applied.
  • Format placeholders survive translation. NumberedSelectionPrompt keeps {0}, PackageSelectionSelected keeps both {0} and {1}, and each carries the matching {Locked=...} comment.
  • Literal command-line tokens stay untranslated. PackageSelectionRefine and PackageSelectionRefineForExport keep --id / --exact / --source / --package-id verbatim and lock them in the comment, so the guidance text remains copy-pasteable.
  • xml:space="preserve" is present on every new <data> element, and angle brackets in the placeholder syntax are escaped as &lt;ID&gt; rather than raw.

No defects found. Approving.

@JohnMcPMS
JohnMcPMS merged commit 94751f2 into microsoft:master Oct 7, 2026
6 checks passed
@JohnMcPMS
JohnMcPMS deleted the loc-update branch October 7, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants