Skip to content

Fix model catalog IPC cloning of reactive provider inputs - #250

Merged
Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/fix-model-catalog-ipc-clone
Oct 23, 2026
Merged

Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/fix-model-catalog-ipc-clone

Conversation

@angnuoli

Copy link
Copy Markdown
Collaborator

Summary

  • Fix An object could not be cloned when loading cloud model catalogs from model settings.
  • Construct a plain ProviderCatalogInput request containing only baseUrl and apiKey at the shared catalog API boundary instead of passing a Vue reactive Proxy to Electron.
  • Keep provider APIs, caching, credentials storage, and sandbox policy unchanged.

Regression coverage

  • Exercise both load and loadConfigured with deeply reactive provider configuration and real structuredClone validation at the mocked IPC boundary.
  • Require cloneable requests in the settings integration test before checking the full live catalog and hot-selecting an unsaved model.
  • The three focused regression cases reproduced the failure before the fix and pass afterward.

Validation

Validated in a clean worktree based on current main, excluding unrelated local feature changes:

  • Full renderer suite: 42 test files / 549 tests passed (vitest run --silent).
  • Vue/TypeScript: vue-tsc --noEmit --pretty false passed.
  • ESLint on the three changed files: zero errors; 16 pre-existing test-stub warnings.
  • Prettier on the three changed files passed.
  • git diff --check passed.

Scope: three files only; no packaging or installation changes.

@angnuoli
Angnuo (angnuoli) merged commit 51f437e into main Oct 23, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant