Skip to content

fix: allow removing Qwen and MiniMax connections - #251

Merged
Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/remove-managed-provider
Oct 23, 2026
Merged

Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/remove-managed-provider

Conversation

@angnuoli

Copy link
Copy Markdown
Collaborator

Description

Restore a removal action for configured Qwen and MiniMax connections. Managed providers intentionally hide the saved-model row list, which also hid the only existing removal action and prevented users from returning to an unconfigured state.

Related Issue

No linked issue.

Changes

  • Add a provider-level Remove connection action with a confirmation dialog.
  • Remove the selected provider's connection and saved API key, model aliases, and associated default/agent model references.
  • Allow removing the last configured provider without choosing another model automatically.
  • Preserve conversations, other providers, security policies, and external credentials/environment variables.
  • Block removal during streaming, recovery, and model operations, and retain optimistic-concurrency checks.
  • Add English/Chinese copy and regression coverage for removal, cancellation, stale writes, and busy states.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing

  • Complete renderer suite: 42 test files, 558 tests passed (vitest run).
  • Renderer production build (npm run build in desktop/renderer).
  • Prettier check for all six changed files.
  • Targeted renderer ESLint: no errors; existing file warnings remain.
  • git diff --check.
  • Manual installed-app testing (not performed; the user's real credentials were not changed).

Checklist

  • Changes are isolated from unrelated work in the original working directory.
  • Self-review performed.
  • Regression tests added.
  • Conversations and unrelated settings are preserved.

@angnuoli
Angnuo (angnuoli) merged commit 9a1f6b7 into main Oct 23, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant