Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Removing executeWorkflow leaves unit tests calling the deleted method and unused imports in the client and integration tests, causing test, type-check, and lint failures.
3 open issues
What changed in this PR
Removes the SDK’s v1 workflow execution API following removal of the server-side functionality. This is a breaking change for callers of Client.executeWorkflow().
Changes:
- Removes
Client.executeWorkflow(). - Deletes
WorkflowResponseand its public export. - Removes the direct workflow execution integration test while retaining polling tests.
| File | Description |
|---|---|
tests/v1/workflows/workflow.integration.ts |
Removes the obsolete execution integration test. |
src/v1/parsing/common/workflowResponse.ts |
Deletes the workflow response wrapper. |
src/v1/parsing/common/index.ts |
Removes the WorkflowResponse export. |
src/v1/client.ts |
Removes the workflow execution method and response import. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Function removed from server.
Types of changes