Skip to content

⚰️ remove dead v1 workflow - #503

Merged
ianardee merged 2 commits into
mainfrom
kill-wf
Nov 2, 2026
Merged

ianardee merged 2 commits into
mainfrom
kill-wf

Conversation

@ianardee

@ianardee ianardee commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Function removed from server.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing executeWorkflow leaves unit tests calling the deleted method and unused imports in the client and integration tests, causing test, type-check, and lint failures.

3 open issues
What changed in this PR

Removes the SDK’s v1 workflow execution API following removal of the server-side functionality. This is a breaking change for callers of Client.executeWorkflow().

Changes:

  • Removes Client.executeWorkflow().
  • Deletes WorkflowResponse and its public export.
  • Removes the direct workflow execution integration test while retaining polling tests.
File Description
tests/​v1/​workflows/​workflow.integration.ts Removes the obsolete execution integration test.
src/​v1/​parsing/​common/​workflowResponse.ts Deletes the workflow response wrapper.
src/​v1/​parsing/​common/​index.ts Removes the WorkflowResponse export.
src/​v1/​client.ts Removes the workflow execution method and response import.

Review effort: Balanced

Comment thread src/v1/client.ts Resolved
Comment thread src/v1/client.ts Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow execution sample still calls the removed executeWorkflow method, causing type-check failures and a JavaScript TypeError.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread src/v1/client.ts Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the removal of the unsupported legacy workflow-execution API.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@ianardee
ianardee merged commit d01a37f into main Nov 2, 2026
24 checks passed
@ianardee
ianardee deleted the kill-wf branch November 2, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants