Repository navigation
Conversation
atesgoral
previously approved these changes
Oct 23, 2026
## Motivation and Context On the 2026-07-28 path the Streamable HTTP transport buffers the notifications a handler emits during a request and writes them as SSE frames ahead of the response once the handler returns. A notification holding a string that is not valid UTF-8, such as log data a tool passed to `notify_log_message`, raised `JSON::GeneratorError` while the frames were written, and the whole exchange was answered with 500, losing the response the handler had produced. The transport now generates each notification when it is buffered. One that cannot be generated is reported to the exception reporter and dropped as non-delivery (`false`), as the buffer already does past its cap, and the other notifications and the response are written as before. ## How Has This Been Tested? `test/mcp/server/transports/streamable_http_transport_test.rb`. Against the previous library the new test answers 500. ## Breaking Changes None.
koic
force-pushed
the
drop_a_buffered_notification_that_cannot_be_generated
branch
from
October 24, 2026 17:33
589234f to
89772bf
Compare
koic
deleted the
drop_a_buffered_notification_that_cannot_be_generated
branch
October 24, 2026 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
On the 2026-07-28 path the Streamable HTTP transport buffers the notifications a handler emits during a request and writes them as SSE frames ahead of the response once the handler returns. A notification holding a string that is not valid UTF-8, such as log data a tool passed to
notify_log_message, raisedJSON::GeneratorErrorwhile the frames were written, and the whole exchange was answered with 500, losing the response the handler had produced.The transport now generates each notification when it is buffered. One that cannot be generated is reported to the exception reporter and dropped as non-delivery (
false), as the buffer already does past its cap, and the other notifications and the response are written as before.How Has This Been Tested?
test/mcp/server/transports/streamable_http_transport_test.rb. Against the previous library the new test answers 500.Breaking Changes
None.
Types of changes
Checklist