Repository navigation
fix: default DB_POOL_TIMEOUT to 5 s - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #105, which left Granian's backpressure at its default. Requests beyond the pool's capacity now wait on the pool, so
DB_POOL_TIMEOUTsets how long an overloaded worker holds a request before answering 503.At 30 s a client under sustained overload waited half a minute for that 503, and most clients and proxies give up sooner, so the 503 often never reached anyone. 5 s still covers a short burst or one slow query and sheds sustained overload quickly. Deployments that need longer can set
DB_POOL_TIMEOUT.Changes
Settings.db_pool_timeoutdefaults to 5 instead of 30.Testing
just test: 87 passed, 100% coverage.ruff format --checkandruff checkare clean.