Repository navigation
fix: cap pytest below 9.2 until pytest-alembic supports it - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 9.2.0 breaks test collection with pytest-alembic 0.13.1 whenever
--test-alembicis passed:AttributeError: 'TestCollector' object has no attribute '_nodeid'(schireson/pytest-alembic#292). The fix is in schireson/pytest-alembic#293 but hasn't been released yet.The lockfile still pins pytest 9.1.1, but
just installrunsuv lock --upgrade, which would move it to 9.2.0. This caps pytest at<9.2. The cap can come off once a pytest-alembic release with the fix is out.Tested in docker:
just test-migrationsandjust testpass. With the cap,uv lock --upgrade-package pyteststays on 9.1.1; without it, it moves to 9.2.0.