Repository navigation
List only blocking issues and subtasks as left behind, and fix the Russian wording - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Left behind by these picks" listed every relation of a shipped issue. A line like
SHOP-35 blocks SHOP-40 → worker: no tag yetmeans SHOP-40 is waiting on SHOP-35, which is no reason to hold the release. Lines like that would bury the real warnings.Changes:
Blockstype ("is blocked by"), and its subtasks.blocks,relates to, parents and any other link type are left out. They still show when you hover over the issue key in the Issues list.Blocks, Jira's default. An instance that renamed it or uses its own dependency type won't get warnings for it. If someone needs that, it could become a setting.Не войдёт с этими тегами:becomesНе войдёт в релиз с выбранными тегами:. The old version didn't say what wouldn't make it in.родительbecomesвходит в. "SHOP-41 родитель SHOP-36" read as if SHOP-41 were the parent.подзадачаbecomesвключает подзадачу, which had the same backwards reading.нужен {tag}becomesнужен тег {tag}.docs/page.mddescribes which relations count.Tests: the hand-pick test now expects the subtask line and no
blocksline. It failed before the change by showingSHOP-35 blocks SHOP-40 → worker: no tag yet. A new test switches to Russian and checks the heading and two lines. The heading assertion has# noqa: RUF001, because ruff reads "Не" and "с" as look-alike Latin letters.just lint-ci,just test-ciandjust test-smokepass.