Repository navigation
PYTHON-5942 Remove redundant local SRV hostname validation tests - #3133
Merged
aclark4life merged 1 commit intoOct 19, 2026
Merged
Conversation
aclark4life
marked this pull request as ready for review
October 16, 2026 23:50
aclark4life
requested review from
NoahStapp
and
a balanced review from Copilot
October 16, 2026 23:50
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The replacement cases fit the existing spec-test harness, and no unresolved issues were identified.
No open issues 🎉
What changed in this PR
Replaces redundant PyMongo-specific SRV hostname tests with shared specification cases, without changing driver behavior.
Changes:
- Adds identical-hostname cases for three- and four-part SRV hostnames.
- Removes the redundant async prose test and its generated sync counterpart.
| File | Description |
|---|---|
| test/test_dns.py | Removes the generated sync prose test. |
| test/srv_seedlist/replica-set/identical-hostnames-valid-three-parts.json | Adds the three-part hostname case. |
| test/srv_seedlist/replica-set/identical-hostnames-valid-four-parts.json | Adds the four-part hostname case. |
| test/asynchronous/test_dns.py | Removes the redundant async prose test. |
Review effort: Balanced
NoahStapp
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5942
Changes in this PR
identical-hostnames-valid-{three,four}-parts.jsonspec tests from DRIVERS-3162 intotest/srv_seedlist/replica-set/.test_srv_hostname_with_three_or_more_parts_may_equal_the_returned_hostnamefromtest_dns.py.Test Plan
test_dns.py(sync + async) against a mongodb-runner replica set: 24 passed each.Checklist
Checklist for Author
Checklist for Reviewer