Repository navigation
PYTHON-6056 Reduce flakiness in search index helper prose tests - #3166
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the search-index polling and retry changes.
No open issues 🎉
What changed in this PR
This PR reduces flakiness in PyMongo’s search index management tests by centralizing polling and retrying transient search service connection errors.
Changes:
- Adds a shared polling helper with a 10-minute timeout and five-second retry interval.
- Uses the helper for index readiness, drop requests, and deletion checks.
- Removes duplicated deletion polling from the prose test.
| File | Description |
|---|---|
test/test_index_management.py |
Mirrors the retry and polling changes in the generated synchronous tests. |
test/asynchronous/test_index_management.py |
Adds asynchronous retry polling and reuses it for readiness and deletion checks. |
Review effort: Balanced
sleepyStick
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6056 followup.
Changes in this PR
Retry up to a 10 minute timeout for transient search index management errors during the search index management tests and their cleanup. Reduce code duplication in similar tests.
Test Plan
Existing test changes.
Checklist
Checklist for Author
Checklist for Reviewer