Repository navigation
DRIVERS-3659 Specify that failpoints in unified tests must not be con… - #2001
Merged
Merged
Conversation
…figured through clients with timeout options
NoahStapp
requested review from
isabelatkinson
and removed request for
isabelatkinson
October 29, 2026 15:32
sanych-sun
reviewed
Nov 3, 2026
jyemin
requested changes
Nov 3, 2026
| lead to unpredictable behavior if different servers were selected for configuring the fail point and executing | ||
| subsequent operations. | ||
|
|
||
| When configuring a fail point, tests MUST NOT use a client entity that specifies timeout options such as `timeoutMS` |
Contributor
There was a problem hiding this comment.
Let's avoid adding a new reference to CSOT via the timeoutMS example?
jyemin
reviewed
Nov 3, 2026
sanych-sun
approved these changes
Nov 3, 2026
sanych-sun
left a comment
sanych-sun
left a comment
Member
There was a problem hiding this comment.
LGTM + here is CSharp patch to validate the changes.
jyemin
approved these changes
Nov 6, 2026
paulinevos
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…figured through clients with timeout options.
The test fixed in this PR is also the only one the violates the new requirement.
Please complete the following before merging:
clusters).