Repository navigation
Conversation
get_is_ignored iterated the ignore rules twice - once for strings and once for callables - so a one-shot iterable (e.g. an iterator) was exhausted before callable rules were collected and they were silently lost. Materialize the rules into a list first. Fixes morepath#22. Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Regression test for issue morepath#22: callable rules keep working when the ignore iterable is a one-shot iterator. Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22.
Problem
get_is_ignorediterates theignorerules twice: once to collect string rules and once to collect callable rules. When the caller passes a one-shot iterable such as an iterator, the first pass exhausts it, so callable rules are silently lost and modules that should be ignored get imported:Fix
Materialize the rules into a list once before the two collection passes. Behavior for lists, single strings and single callables is unchanged.
Tests
New regression test
test_ignore_module_function_in_iteratorpasses a callable rule insideiter([...])and asserts the matched module is not imported. It fails on master and passes with this change. Full test suite: 24 passed.