Skip to content

dvh, svw, vmin, vmax and every other viewport unit but vw and vh compile to nothing #516

Open

Description

@YevheniiKotyrlo

Before submitting a new issue

  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

css-values-4 §6.1.2 defines vi, vb, vmin and vmax beside vw and vh, and a small, large and dynamic form of each (svw, lvh, dvmin, …) for a browser whose toolbars expand and retract. A React Native window has no such toolbar, so each of those viewports is the window. parseLength (src/compiler/declarations.ts) compiles vw and vh and sends every other viewport length to addWarning("value", …), so height: 100dvh, the usual way to fill the screen on the web, compiles to nothing. parseMediaFeatureValue reads a media or container bound through the same parseLength, so (width > 50dvw) never matches either.

Chromium 156, Firefox 157 and WebKit 27.2 compute each width, about 133.4px for 10vmax, and match each condition. On main (2421ea7) each element renders with no style and no condition matches. #426 (40bfda2) resolves vw and vh in a condition against the window, so (width > 50vw) matches there, and dvw and vmin stay unresolved.

Library version

main at 2421ea7 (0.0.0-nightly.2421ea7)

Environment info

System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 155.26 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    API Levels:
      - "33"
      - "35"
      - "35"
      - "35"
      - "36"
      - "37"
    Build Tools:
      - 35.0.0
      - 36.0.0
      - 36.1.0
      - 37.0.0
    System Images:
      - android-26 | Google APIs Intel x86_64 Atom
      - android-28 | Google APIs Intel x86_64 Atom
      - android-29 | Google APIs Intel x86_64 Atom
      - android-30 | Google APIs Intel x86_64 Atom
      - android-31 | Google APIs Intel x86_64 Atom
      - android-32 | Google APIs Intel x86_64 Atom
      - android-33 | Google APIs Intel x86_64 Atom
      - android-34 | Google APIs Intel x86_64 Atom
      - android-35 | Google APIs Intel x86_64 Atom
      - android-36.1 | Google Play Intel x86_64 Atom
      - android-36.1 | Pre-Release 16 KB Page Size Google Play Intel x86_64 Atom
      - android-37.0 | Google APIs Intel x86_64 Atom
    Android NDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Steps to reproduce

  1. Clone the reproducer branch, which is main at 2421ea7 with one file added, src/__tests__/native/viewport-length-variants.test.tsx, and install:
    git clone --branch repro/516-viewport-length-variants https://github.com/YevheniiKotyrlo/react-native-css
    cd react-native-css
    yarn install
  2. Run yarn jest src/__tests__/native/viewport-length-variants.test.tsx.

src/__tests__/native/viewport-length-variants.test.tsx:

// A React Native window has no browser toolbar to show or hide, so its small, large and dynamic viewports are the window, and vmin and vmax its shorter and longer side
import { render, screen } from "@testing-library/react-native";
import { View } from "react-native-css/components/View";
import { registerCSS } from "react-native-css/jest";

test.each([
  ["10dvw", 75],
  ["10svw", 75],
  ["10lvw", 75],
  ["10vi", 75],
  ["10vmin", 75],
  ["10vmax", 133.4],
])("width: %s on the 750x1334 jest window is %p", (length, width) => {
  registerCSS(`.child { width: ${length}; }`);
  render(<View testID="child" className="child" />);
  expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
});

test.each([
  ["(width > 50vw)", true],
  ["(width > 50dvw)", true],
  ["(width > 50vmin)", true],
])(
  "@media %s on the 750x1334 jest window matches: %s",
  (condition, expected) => {
    registerCSS(`
    .child { width: 10px; }
    @media ${condition} { .child { width: 37px; } }
  `);
    render(<View testID="child" className="child" />);
    expect(screen.getByTestId("child").props.style.width === 37).toBe(expected);
  },
);

Expected: height: 100dvh and every other viewport length compile to the window's size, and a media or container bound in one compares.

Actual: each compiles to nothing, with a value warning, and a bound in one never compares.

The run's output on main at 2421ea7, Windows 11, Node 26.12.1
FAIL src/__tests__/native/viewport-length-variants.test.tsx
  × width: 10dvw on the 750x1334 jest window is 75 (17 ms)
  × width: 10svw on the 750x1334 jest window is 75 (5 ms)
  × width: 10lvw on the 750x1334 jest window is 75 (1 ms)
  × width: 10vi on the 750x1334 jest window is 75 (1 ms)
  × width: 10vmin on the 750x1334 jest window is 75 (1 ms)
  × width: 10vmax on the 750x1334 jest window is 133.4 (1 ms)
  × @media (width > 50vw) on the 750x1334 jest window matches: true (2 ms)
  × @media (width > 50dvw) on the 750x1334 jest window matches: true (1 ms)
  × @media (width > 50vmin) on the 750x1334 jest window matches: true (1 ms)
  ● width: 10dvw on the 750x1334 jest window is 75
    expect(received).toStrictEqual(expected) // deep equality
    Expected: {"width": 75}
    Received: undefined
      14 |   registerCSS(`.child { width: ${length}; }`);
      15 |   render(<View testID="child" className="child" />);
    > 16 |   expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
         |                                                   ^
      17 | });
      18 |
      19 | test.each([
      at toStrictEqual (src/__tests__/native/viewport-length-variants.test.tsx:16:51)
  ● width: 10svw on the 750x1334 jest window is 75
    expect(received).toStrictEqual(expected) // deep equality
    Expected: {"width": 75}
    Received: undefined
      14 |   registerCSS(`.child { width: ${length}; }`);
      15 |   render(<View testID="child" className="child" />);
    > 16 |   expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
         |                                                   ^
      17 | });
      18 |
      19 | test.each([
      at toStrictEqual (src/__tests__/native/viewport-length-variants.test.tsx:16:51)
  ● width: 10lvw on the 750x1334 jest window is 75
    expect(received).toStrictEqual(expected) // deep equality
    Expected: {"width": 75}
    Received: undefined
      14 |   registerCSS(`.child { width: ${length}; }`);
      15 |   render(<View testID="child" className="child" />);
    > 16 |   expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
         |                                                   ^
      17 | });
      18 |
      19 | test.each([
      at toStrictEqual (src/__tests__/native/viewport-length-variants.test.tsx:16:51)
  ● width: 10vi on the 750x1334 jest window is 75
    expect(received).toStrictEqual(expected) // deep equality
    Expected: {"width": 75}
    Received: undefined
      14 |   registerCSS(`.child { width: ${length}; }`);
      15 |   render(<View testID="child" className="child" />);
    > 16 |   expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
         |                                                   ^
      17 | });
      18 |
      19 | test.each([
      at toStrictEqual (src/__tests__/native/viewport-length-variants.test.tsx:16:51)
  ● width: 10vmin on the 750x1334 jest window is 75
    expect(received).toStrictEqual(expected) // deep equality
    Expected: {"width": 75}
    Received: undefined
      14 |   registerCSS(`.child { width: ${length}; }`);
      15 |   render(<View testID="child" className="child" />);
    > 16 |   expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
         |                                                   ^
      17 | });
      18 |
      19 | test.each([
      at toStrictEqual (src/__tests__/native/viewport-length-variants.test.tsx:16:51)
  ● width: 10vmax on the 750x1334 jest window is 133.4
    expect(received).toStrictEqual(expected) // deep equality
    Expected: {"width": 133.4}
    Received: undefined
      14 |   registerCSS(`.child { width: ${length}; }`);
      15 |   render(<View testID="child" className="child" />);
    > 16 |   expect(screen.getByTestId("child").props.style).toStrictEqual({ width });
         |                                                   ^
      17 | });
      18 |
      19 | test.each([
      at toStrictEqual (src/__tests__/native/viewport-length-variants.test.tsx:16:51)
  ● @media (width > 50vw) on the 750x1334 jest window matches: true
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      29 |   `);
      30 |     render(<View testID="child" className="child" />);
    > 31 |     expect(screen.getByTestId("child").props.style.width === 37).toBe(expected);
         |                                                                  ^
      32 |   },
      33 | );
      34 |
      at toBe (src/__tests__/native/viewport-length-variants.test.tsx:31:66)
  ● @media (width > 50dvw) on the 750x1334 jest window matches: true
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      29 |   `);
      30 |     render(<View testID="child" className="child" />);
    > 31 |     expect(screen.getByTestId("child").props.style.width === 37).toBe(expected);
         |                                                                  ^
      32 |   },
      33 | );
      34 |
      at toBe (src/__tests__/native/viewport-length-variants.test.tsx:31:66)
  ● @media (width > 50vmin) on the 750x1334 jest window matches: true
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      29 |   `);
      30 |     render(<View testID="child" className="child" />);
    > 31 |     expect(screen.getByTestId("child").props.style.width === 37).toBe(expected);
         |                                                                  ^
      32 |   },
      33 | );
      34 |
      at toBe (src/__tests__/native/viewport-length-variants.test.tsx:31:66)
Test Suites: 1 failed, 1 total
Tests:       9 failed, 9 total
Snapshots:   0 total
Time:        1.071 s, estimated 2 s
Ran all test suites matching /src\\__tests__\\native\\viewport-length-variants.test.tsx/i.

Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/516-viewport-length-variants

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions