Skip to content

Enable app optimization with R8 - #17699

Open
PhilLab wants to merge 9 commits into
masterfrom
r8_minify
Open

Enable app optimization with R8#17699
PhilLab wants to merge 9 commits into
masterfrom
r8_minify

Conversation

@PhilLab

@PhilLab PhilLab commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Related to #17640

@PhilLab
PhilLab marked this pull request as draft September 23, 2026 14:29
@PhilLab PhilLab added enhancement performance 🚀 Performance improvement opportunities (non-crash related) labels Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 4bbd08f
Version 17699
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96 alperozturk96 self-assigned this Oct 6, 2026
@alperozturk96

alperozturk96 commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Gplay variant tested for apk size

Before After
111.7mb 89.8mb

@alperozturk96
alperozturk96 marked this pull request as ready for review October 7, 2026 10:02
PhilLab and others added 8 commits October 7, 2026 12:04
@PhilLab @alperozturk96
feat(build): First step towards R8 minify - still crashing
ac20857 
With keeping the apache httpclient, webdav and ical4j, the app at least
starts.

But it crashes when clicking the plus button (OCFileListBottomSheetDialog).

Related to #17640

Assisted-by: GithubCopilot:GPT-5.4
Signed-off-by: Philipp Hasper <vcs@hasper.info>
@PhilLab @alperozturk96
feat(build): gradle property to control optimization, set for CI
d5683ad 
This adds a property to enable the optimization, and it is activated for
the CI
- build
- screenshot tests
- instrumentation tests
- unit test (though probably without effect)

For this to work, it must also be present in the debug build variant

Signed-off-by: Philipp Hasper <vcs@hasper.info>
@alperozturk96
add new rules
6fc2088 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update agents md
a3d79bb 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove pminify
e3fe0d0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix slide behaviour crash when going back from settings
a559af2 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove pmnifiy
a171932 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update license header and remove comments
0f914a6 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
alperozturk96 reviewed Oct 7, 2026
View reviewed changes
Comment thread app/build.gradle.kts Outdated

debug {
optimization {
enable = true

@alperozturk96 alperozturk96 Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can disable later on once we sure about the rules.

@alperozturk96

alperozturk96 commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I completed testing for the following areas:

  • Encrypted folder creation
  • File uploads
  • Move, copy, remove operations
  • File downloads
  • Media and album functionality
  • Settings, including theme changes, passcode, and storage location, toggles, links
  • Folder and file actions
  • File and folder detail actions
  • Media previews
  • Shared, Favorites, Recent, Uploads, Community, Trashbin, Activities, On device tabs

We can merge this into the master branch and monitor feedback over the next couple of releases. We can continue using the non-optimized version for now, which should give us enough time to validate the rules and make sure everything is working as expected.

@tobiasKaminsky @daniele-verducci fyi.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

stable35-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96
fix garm
4bbd08f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3030
Correctness5454
Dodgy code177177
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1616
Total341341

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes
@daniele-verducci daniele-verducci Awaiting requested review from daniele-verducci
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

@alperozturk96 alperozturk96

Labels

3. to review AI assisted enhancement feedback-requested performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PhilLab @alperozturk96