refactor(client-repository)

[alperozturk96]

Changes

• Injects RemoteClientRepository thus via

  val client = clientRepository?.getNextcloudClient()

  instead

  final User user = accountManager.getUser();
  
  if (user.isAnonymous()) {
      return;
  }
  
  final Context context = MainApp.getAppContext();
  NextcloudClient nextcloudClient = null;
  try {
      nextcloudClient = OwnCloudClientManagerFactory
          .getDefaultSingleton()
          .getNextcloudClientFor(
              user.toOwnCloudAccount(),
              context);
  } catch (OperationCanceledException | AuthenticatorException | IOException e) {
      Log_OC.e(this, "Error retrieving user quota", e);
  }

• Mark client factory as deprecated

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	a880fd2
Version	17790
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	30	30
Correctness	54	54
Dodgy code	177	177
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	26	26
Performance	35	35
Security	16	16
Total	341	341

[codecov]

Codecov Report

❌ Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...com/nextcloud/repository/RemoteClientRepository.kt	41.66%	7 Missing ⚠️
...d/android/ui/fragment/albums/AlbumItemsFragment.kt	0.00%	7 Missing ⚠️

📢 Thoughts on this report? Let us know!