Repository navigation
Conversation
Visit cached descendants even when their parent ETag is unchanged and persist newly discovered folders before visiting their children. Process missing files sequentially within the foreground two-way sync worker. Keep manual service dispatch, propagate transfer errors to the root, check ongoing constraints between files, and save completion status using fresh folder metadata. Cover traversal, cancellation, error handling, operation reuse, and worker completion with unit tests. Assisted-by: Codex:gpt-6.1-sol Signed-off-by: Oskars Pucka <89988568+oskarsss@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enabling sync on a folder could leave deeply nested files undownloaded. An unchanged parent folder ETag could prevent traversal into its descendants.
Changes
Testing
An earlier test.2 device run downloaded 1,213 additional files totaling 6.50 GB in approximately 44 minutes. All newly downloaded file sizes matched the server, and three sampled deep files also matched server SHA-256 hashes.
These measurements demonstrate recursive download completion; they are not a controlled speed comparison with the original app.
Test APK
https://github.com/oskarsss/android/releases/tag/stable-35.0.1-recursive-sync-test.3
Known limitations
Manual Sync and Sync all transfers, encrypted folders, and upload/conflict behavior have not been verified in the latest device run.
Stable QA lint reports an existing ObsoleteSdkInt error in unchanged QA icon resources.
AI assistance
Implementation, cleanup, and automated testing were assisted by Codex (GPT-6.1-Sol).