Skip to content

refactor(intent): simplify deep link and file intent handling - #17888

Open
alperozturk96 wants to merge 3 commits into
masterfrom
refactor/deep-link-file-intent-handling
Open

refactor(intent): simplify deep link and file intent handling#17888
alperozturk96 wants to merge 3 commits into
masterfrom
refactor/deep-link-file-intent-handling

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue

  • Opening a file link from Talk (…/f/) showed "Associated account not found".
  • The link's server was compared with each account's saved server URL as an exact string, so letter case, a trailing /, /index.php, default ports or http vs https made it fail.

Android Common PR: nextcloud/android-common#1093

Android Talk PR: nextcloud/talk-android#6956

How to test?

  • Open account from Talk
  • Open same account in Files
  • Tap file link from Talk
  • It should open file in Files

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 changed the title Refactor/deep link file intent handling refactor(intent): simplify deep link and file intent handling Oct 27, 2026
This was referenced Oct 27, 2026
Open
Open
@alperozturk96 alperozturk96 linked an issue Oct 27, 2026 that may be closed by this pull request
opening file links from talk -> error #17573
Open
@alperozturk96 alperozturk96 mentioned this pull request Oct 27, 2026
Open
@codecov

codecov Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtcloud/client/account/UserAccountManagerImpl.java 40.00% 2 Missing and 4 partials ⚠️
...ndroid/providers/UsersAndGroupsSearchProvider.java 0.00% 4 Missing ⚠️
.../java/com/owncloud/android/ui/AvatarGroupLayout.kt 0.00% 4 Missing ⚠️
...m/nextcloud/client/account/UserAccountManager.java 0.00% 1 Missing ⚠️
...m/owncloud/android/ui/adapter/ShareeListAdapter.kt 0.00% 1 Missing ⚠️
...ud/android/ui/fragment/ProfileBottomSheetDialog.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

tobiasKaminsky
tobiasKaminsky previously requested changes Oct 28, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/client/account/UserAccountManagerImpl.java
return true;
}

String userId = accountManager.getUserData(account, AccountUtils.Constants.KEY_USER_ID);

@tobiasKaminsky tobiasKaminsky Oct 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the key_user_id always the same like account.name?
I think this can be different.
Account can be tobias@mail.com@server.com
-> name tobias@mail.com
-> userId (internal userid from server) might then be tobias or ldap id.

@alperozturk96 alperozturk96 Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KEY_USER_ID is not same like account.name always and this is right comparison. Otherwise it will fail like old code.

see, this only set via authenticator code:

Image

Old code should fail via LDAP for example. We are checking here file belongs this account or not that's all.

Comment thread gradle/libs.versions.toml

[versions]
androidCommonLibraryVersion = "0.34.0"
androidCommonLibraryVersion = "f6515c1c36"

@tobiasKaminsky tobiasKaminsky Oct 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change after merging upstream?

@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from 0b48676 to 873ad22 Compare October 28, 2026 08:11
@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from 873ad22 to fe7f345 Compare October 28, 2026 12:14
daniele-verducci
daniele-verducci approved these changes Oct 28, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested like we did in call and it works. User id comparison make sense to me (based on what we have seen in the debugger)

@alperozturk96

alperozturk96 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Tested like we did in call and it works. User id comparison make sense to me (based on what we have seen in the debugger)

nextcloud/android-common#1093

can i get review for common also :)

@alperozturk96
fix(account-name): parsing
5172ae7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor(intent): simplify deep link and file intent handling
855b41a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Without a user ID there is nothing reliable to compare ownerId agains…
57a4594 
…t thus use is shared with me

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from fe7f345 to 57a4594 Compare October 30, 2026 12:25
@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown

stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17888-IT-stable22-12-53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review AI assisted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opening file links from talk -> error

3 participants

@alperozturk96 @tobiasKaminsky @daniele-verducci