Skip to content

docs: document user-key SSE drawbacks - #15449

Open
xhon-pelushi wants to merge 2 commits into
nextcloud:masterfrom
xhon-pelushi:fix/docs-14086-user-key-group-share-drawbacks
Open

xhon-pelushi wants to merge 2 commits into
nextcloud:masterfrom
xhon-pelushi:fix/docs-14086-user-key-group-share-drawbacks

Conversation

@xhon-pelushi

Copy link
Copy Markdown
Contributor

Document user key / SSE drawbacks for group shares.

Fixes #14086

Test plan

  • Review diff against issue
  • Run project lint/tests if applicable

Fixes nextcloud#14086

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core point is right. "The share must be removed and re-created" isn't certain though, a later write re-encrypts for the current access list too. Could you soften it? The bold lead-ins don't match the bullets around them either.

Keys are updated on the next write or re-share, no need to recreate the
share. Drop bold lead-ins to match the surrounding bullets.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document user key draw backs (SSE)

2 participants