Skip to content

fix(submit): move on to the submit button after the last answer - #3952

Merged
Chartman123 merged 1 commit into
mainfrom
fix/submit-enter-skip-clear
Nov 21, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/submit-enter-skip-clear

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Enter in the last answer of a form focused the "Clear form" button, as it comes first among the buttons, so a second Enter opened the dialog to clear all answers instead of sending them. Enter now skips that button and reaches "Submit".

Found in the review of #3637, which reworks the Enter handling of the submit view and fixes the same in its own code.

How to verify

Fill the last question of a form (a short answer) and press Enter: the focus is on "Submit", not on "Clear form".

Checked live on NC 36 (focus on "Clear form" before, on "Submit" after). Playwright test added in submit-form.spec.ts.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Enter in the last answer of a form focused the button that clears the
form, as it comes first among the buttons. A second Enter opened the
dialog to clear all answers instead of sending them.

Enter now skips that button, so it reaches the button that submits
the form.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews labels Nov 21, 2026
@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 21, 2026
@Chartman123

Copy link
Copy Markdown
Collaborator

/backport to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 21, 2026
@Chartman123
Chartman123 merged commit fe32ae7 into main Nov 21, 2026
43 checks passed
@Chartman123
Chartman123 deleted the fix/submit-enter-skip-clear branch November 21, 2026 09:04
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants