Repository navigation
fix(results): draw the bar track dark in Chromium dark mode - #3985
Open
AndyScherzinger wants to merge 1 commit into
Open
AndyScherzinger wants to merge 1 commit into
AndyScherzinger wants to merge 1 commit into
Conversation
The results bars only gave the meter element itself a background. Chromium and other Blink browsers draw the track with their own ::-webkit-meter-bar style, a light gradient, so in dark mode every bar had a nearly white track, while Firefox showed the dark one. The track pseudo-element now gets the same background and radius as the meter. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
|
/backport to stable5.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Chromium-based browsers (Chrome, Edge, Brave and others) the track of every bar in the results summary is nearly white in dark mode, so the bars look like bright stripes. Firefox shows the intended dark track.
The results style gives the
<meter>element itself a background, but Chromium draws the track with its own::-webkit-meter-barpseudo-element, whose default is a light gradient. Our rule for that pseudo-element only set its height.Change
::-webkit-meter-barinResultsSummary.vuegets the same background (--color-background-dark) and radius as the meter, so the track follows the theme in every browser. Firefox and light mode look the same as before.Screenshots
How to verify
🤖 AI (if applicable)