Repository navigation
feat: Manage Trusted Servers via OCC command - #63440
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
515194a to
565791a
Compare
cefe9ae to
1b784b8
Compare
|
@cristianscheid I hope all is fine now. 3 failing pipelines, but I think that's not related to this change. Can you verify those for me ? 😃 |
Yes it was fine, was just a matter of re-running the jobs and they passed. Tyvm! |
|
Hi @CarlSchwan and @cristianscheid , please can you review that it can be merged? |
|
Do we want all 3 commands in one file? We usually do one file per command. |
@SebastianKrupinski this was a suggestion by Carl on previous comment: Docs reference: |
|
@SebastianKrupinski @CarlSchwan can this be merge ? |
come-nc
left a comment
There was a problem hiding this comment.
Code looks good apart from license question
|
Thanks @come-nc ! Applied your suggestion. |
|
Hi @T0mWz Can you also please squash the commits |
Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
|
Done @SebastianKrupinski 😀 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Issue
As an administrator, I currently have to manually add each URL one by one as a trusted server via the Web Interface. From an administrative standpoint, the ability to add a single URL or a list of URLs via the shell would be highly desirable.
See submitted issue; #63439
Wish
Add an OCC option to list and manage federated trusted servers. This would eliminate the need for multiple clicks and copy-and-paste actions. But it also makes automated management easier.
Usage
Notes
--listignores the servers argument;--add/--removerequire at least one URL — enforced viaINVALID(exit 2) return codes.--removetakes a URL rather than an id (matching your ask), so findServerId() re-applies the samehttps://prefix + trailing-slash trim thatTrustedServers::addServer()used when the row was stored, then matches againstgetServers()to find the idremoveServer(int $id)needs.STATUS_OKetc.) are mapped to readable labels in the--listtable.