Skip to content

fix(occ): honour --quiet during early loadCommands warnings - #65240

Merged
come-nc merged 1 commit into
nextcloud:masterfrom
whoalin1:fix/occ-quiet-loadcommands
Nov 10, 2026
Merged

come-nc merged 1 commit into
nextcloud:masterfrom
whoalin1:fix/occ-quiet-loadcommands

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #19974

occ --quiet / -q did not silence the early stderr messages emitted while commands are loaded (require upgrade, low memory, maintenance mode). Only the custom --no-warnings flag forced QUIET before those writes. Apply the same verbosity for Symfony --quiet and skip those writes when the output is quiet.

Test plan

  • With a pending upgrade: php occ status --quiet prints nothing about “require upgrade”
  • php occ upgrade --quiet --no-interaction has no early loadCommands chatter on stderr
  • Without --quiet, the same messages still appear
  • --no-warnings behaviour unchanged

AI disclosure

This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.

All commits carry an Assisted-by: Cursor:grok-4.7 trailer.

@whoalin1
whoalin1 requested a review from a team as a code owner October 7, 2026 01:24
@whoalin1
whoalin1 requested review from Altahrim, come-nc, icewind1991 and salmart-dev and removed request for a team October 7, 2026 01:24
@whoalin1
whoalin1 force-pushed the fix/occ-quiet-loadcommands branch from 2aceb38 to 5fd8138 Compare October 9, 2026 14:10
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@whoalin1

Copy link
Copy Markdown
Contributor Author

Checked the failing checks here — all four (check-ai-trailers, gate, merge-reports, playwright-test-summary) are CI-infrastructure artifacts, not issues with this PR's code:

  • gate intentionally fails via core.setFailed('Skipping Playwright: draft state, missing labels or no playwright path changes.') when a PR doesn't touch tests/playwright/* and doesn't yet have the 3. to review/4. to release/force-e2e-tests labels. That's by design to skip the Playwright matrix for non-UI changes — only a maintainer applying one of those labels (or the PR reaching review) clears it.
  • merge-reports and playwright-test-summary then fail because they depend on a Playwright run artifact/cache (playwright-context-<run id>) that was never produced, since the Playwright jobs were skipped.
  • check-ai-trailers detects the Assisted-by: Cursor:grok-4.7 trailer correctly, then fails trying to add the "AI assisted" label: gh: Resource not accessible by integration (HTTP 403). The GITHUB_TOKEN for a pull_request-triggered run from a fork only has read permissions, so the label-write step can't succeed regardless of the PR contents.

All actual code checks (php-lint, php-cs, phpunit/nodb/sqlite/pgsql/oci suites, static-code-analysis, stylelint, reuse-compliance) are green. I don't see anything in this PR's diff to change for these four; they look like they'd fail the same way for any external PR lacking the review/release labels. Flagging in case the label permissions or the gate step need a maintainer-side tweak (e.g. pull_request_target or an explicit issues: write permission for check-ai-trailers).

@come-nc come-nc added 3. to review Waiting for reviews AI assisted labels Nov 9, 2026
@come-nc come-nc added this to the Nextcloud 36 milestone Nov 9, 2026
Assisted-by: Cursor:grok-4.7
Signed-off-by: whoalin1 <whoalin414@gmail.com>
@come-nc
come-nc force-pushed the fix/occ-quiet-loadcommands branch from 5fd8138 to 9acb851 Compare November 9, 2026 16:49
@come-nc
come-nc merged commit 4d89725 into nextcloud:master Nov 10, 2026
202 of 208 checks passed
@welcome

welcome Bot commented Nov 10, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide occ upgrade output when using --quiet

3 participants