Repository navigation
Conversation
…quested path Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Mario Alfonso Pym Mejía <pymm@hitss.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Friendly ping for review when you have a moment. The branch is up to date with master and merges cleanly. Thanks! |
Summary
The Favorites view fails with a 500 error ("Failed to get relative path") after the preview of a deleted favorite file was requested from the trash bin.
Root::getFirstNodeByIdInPath()reuses the cached path for a file id when it starts with the requested path. But/user/files_trashbin/files/x.txtalso starts with/user/files, so a node from the trash bin is returned for the user's files and the REPORT request fails.This checks that the cached path is actually inside the requested path, using
PathHelper::getRelativePath()asgetByIdInPath()already does when filtering its results.How to test
REPORT /remote.php/dav/files/<user>/request fails with 500Failed to get relative path for /<user>/files_trashbin/files/<name>.d<timestamp>Checklist
3. to review, feature component)stable32)AI (if applicable)