Repository navigation
Conversation
2013eee to
cc06e61
Compare
|
/backport to stable35 |
|
/backport to stable34 |
|
/backport to stable33 |
…ess book Assisted-by: omp:claude-opus-5-5 Signed-off-by: hamza <hamzamahjoubi221@gmail.com>
cc06e61 to
4a4aad0
Compare
| * Applies the access rules of {@see SystemAddressbook} for a given viewer | ||
| * outside of a DAV request. | ||
| */ | ||
| class SystemAddressBookVisibility { |
There was a problem hiding this comment.
nit: I would prefer SystemAddressbookAccess 🙈
There was a problem hiding this comment.
It's actually visibility ( visibility in contacts app) you can have access but not be visible in contacts app
| * Applies the access rules of {@see SystemAddressbook} for a given viewer | ||
| * outside of a DAV request. | ||
| */ | ||
| class SystemAddressBookVisibility { |
There was a problem hiding this comment.
| class SystemAddressBookVisibility { | |
| class SystemAddressbookVisibility { |
To stay in sync with the SystemAddressbook class.
|
Let's merge this one after #63392. It changes the system address book visibility rules (adds shareapi_only_share_with_group_members and the exclude list), so SystemAddressBookVisibility needs to be re-checked against them afterwards. |
|
Hey, I finally got a min to look through this properly. You're right in our team call, I got contacts integration confused contacts search, the system address book filters are not applied. That said here are the issues I see with this implementation:
My recommendation, drop CardSearchDao.php use OCP\Contacts\IManager::Search() to find the existing contact, or OCP\Contacts\IManager::getUserAddressBooks() and loop through the address books. Using the IManager will correct all 3 of the above points |
|
@hamza221 Thank you so much for your work! |
|
As it's still in development according to the tag, I'll change it back to a draft. |
Summary
Don't create a recently contacted card when the user interacts with a contact that's in one of their addressbooks, including cards in system addressbook that are visible to the user.
Checklist
3. to review, feature component)stable32)AI (if applicable)