Repository navigation
fix(files_sharing): respect openfile parameter for external file shares - #65997
Open
sundeep8967 wants to merge 1 commit into
Open
sundeep8967 wants to merge 1 commit into
sundeep8967 wants to merge 1 commit into
Conversation
Contributor
|
looks good, but please add a playwright regression test for this. |
sundeep8967
force-pushed
the
fix/public-share-respect-openfile-param-65814
branch
from
November 8, 2026 16:47
228053b to
436a30b
Compare
sundeep8967
requested review from
kristian-zendato,
skjnldsv and
susnux
and removed request for
a team
November 8, 2026 16:47
Author
|
Added the Playwright regression test under |
When navigating to an external single-file share with `openfile=false`, the public router initialization previously hardcoded `openfile: 'true'` in goToRoute(), causing the file viewer to open automatically even when explicitly requested not to autoplay or open. Check the current query parameter and preserve 'false' when provided. Fixes nextcloud#65814 Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
sundeep8967
force-pushed
the
fix/public-share-respect-openfile-param-65814
branch
from
November 9, 2026 22:02
436a30b to
66eb628
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When navigating to an external single-file share link with
?openfile=false,apps/files_sharing/src/init-public.tspreviously hardcodedopenfile: 'true'during router redirection. This caused the viewer to autoplay or open the file even when explicitly requested not to open it.This PR checks the current query parameter
window.OCP.Files.Router.query.openfileand preserves'false'when supplied; otherwise it defaults to'true'.Checklist
3. to review, feature component)stable32)AI (if applicable)