Repository navigation
fix(core): drop unused bruteforce_attempts_ip index - #66000
Merged
Merged
Conversation
Brute force attempts are only looked up and reset by subnet, and the cleanup job filters on the occurred column. No query filters on ip, so the index only adds write overhead on every registered attempt. Fixes #49841 Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
susnux
reviewed
Oct 29, 2026
Contributor
There was a problem hiding this comment.
also remove from the old index where this was added
Contributor
Author
There was a problem hiding this comment.
Done. the failing test i think it's a test issue not something relevent to what i pushed
Fresh installs no longer create the index, and the migration test is dropped as it only covered a trivial schema change. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
susnux
approved these changes
Oct 29, 2026
leftybournes
approved these changes
Oct 30, 2026
Contributor
|
This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brute force attempts are only looked up and reset by subnet, and the cleanup job filters on the occurred column. No query filters on ip, so the index only adds write overhead on every registered attempt.
Fixes #49841
Assisted-by: ClaudeCode:claude-opus-5-5
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)