Repository navigation
Conversation
lazerg
requested review from
CarlSchwan,
come-nc,
provokateurin and
sorbaugh
and removed request for
a team
October 31, 2026 08:08
come-nc
reviewed
Nov 9, 2026
Comment on lines
+129
to
+132
| $items = iterator_to_array($this->cache->get($url, $token, $offset, $count), false); | ||
| if (in_array(null, $items, true)) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
This loads all items in memory instead of streaming using the generator.
Can you explain better what you are trying to fix?
When is null yielded by the cache?
Contributor
Author
There was a problem hiding this comment.
The null comes from PaginateCache::get() when the count key is still there but one of the row entries was evicted (typical with APCu as the only cache, see #62538), so writeRaw(null) throws and the request 500s. It streams from the generator again now and just stops at the first missing entry, then falls back to the normal response.
Assisted-by: Claude:claude-opus-5-5 Signed-off-by: lazerg <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-65080-paginate-evicted-entries
branch
from
November 9, 2026 16:56
793b0fa to
92066ee
Compare
come-nc
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the pagination cache loses individual entries but keeps the count key,
PaginatePlugin::onMethod()passednulltoXMLWriter::writeRaw()and the request failed with a 500. The loop now stops at the first missing entry, and the request is handled like one without a pagination token.AI disclosure: this change was prepared with Claude (claude-opus-5-5) and reviewed by me.
Fixes #65080