Skip to content

[stable34] fix(dav): pair changed iTip instances by UID/RECURRENCE-ID instead of array position - #66379

Open
SebastianKrupinski wants to merge 1 commit into
stable34from
backport/66015/stable34
Open

SebastianKrupinski wants to merge 1 commit into
stable34from
backport/66015/stable34

Conversation

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Manual backport of #66015 (original: #64635). The automated backport failed.

Changes from the stable35 version

  • IMipService::INSTANCE_DIFF_PROPERTIES is declared as private const instead of private const array. Typed class constants need PHP 8.3, and stable34 supports PHP 8.2, where the original is a parse error.
  • EventComparisonService and its test had modify/delete conflicts. They are deleted as in the original, because stable34's copies only differ in whitespace and an untyped constant.

Testing

apps/dav/tests/unit/CalDAV/ passes on PHP 8.2 and 8.3 (760 tests).

AI

  • The content of this PR was partly or fully generated using AI

🤖 Generated with Claude Code

@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 34.0.6 milestone Nov 5, 2026
@SebastianKrupinski
SebastianKrupinski requested review from icewind1991 and provokateurin and removed request for a team November 5, 2026 17:05
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@SebastianKrupinski SebastianKrupinski added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 5, 2026
… array position

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish AI assisted backport-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants