Repository navigation
Conversation
getShareByToken() treats these as not found, so the link never works and the duplicate check misses them. The check only runs when the token changes, so existing shares stay editable. Signed-off-by: Okba Allaoua <o.allaoua@esi-sba.dz> Assisted-by: ClaudeCode:claude-opus-5-5
ELHart05
requested review from
GhassenKefi,
leftybournes,
pabzm and
salmart-dev
and removed request for
a team
November 7, 2026 14:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A custom share token equal to a username saved without an error, but the link then returned a 404. Two shares could also end up with the same token.
getShareByToken()deliberately treats a username as not found, and the duplicate check inupdateShare()swallowed that result.updateShare()now refuses a new token that equals a username, and the sharing form shows the error.generateToken()had the same gap, so it skips usernames too.The check only runs when the token changes, so an existing share stays editable if a user later takes that name.
The error reuses the existing "already exists" text, so it doesn't say a user exists. A refusal does still show the token is taken, so someone allowed to set custom tokens could use it to probe usernames. Happy to change the approach if you'd prefer something else.
Tested on a local instance through the API and the sharing form.
Checklist
3. to review, feature component)stable32)AI (if applicable)