Repository navigation
fix(core): resolve user timezone via IUserSession in DateTimeZone - #66522
Open
isihussain wants to merge 1 commit into
Open
isihussain wants to merge 1 commit into
isihussain wants to merge 1 commit into
Conversation
When DateTimeZone is initialized during early registration, it captures the initial session (where user_id is null). By checking IUserSession when no explicit userId is provided, web requests resolve the authenticated user preference while keeping session fallback for CLI and background jobs. Signed-off-by: isihussain <35667459+isihussain@users.noreply.github.com>
isihussain
requested review from
Altahrim and
CarlSchwan
and removed request for
a team
November 11, 2026 12:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTimeZoneis constructed during early app registration, it captures the initialMemorysession before session initialization. Consequently, subsequent calls toIDateTimeZone::getTimeZone()without an explicit$userIdreaduser_idasnullfrom the stale session reference and fallback to UTC.?IUserSession $userSession = nullintoDateTimeZoneand check$this->userSession?->getUser()?->getUID()before falling back to$this->session->get('user_id').$userIdcalls.tests/lib/DateTimeZoneTest.php.Checklist
AI (if applicable)