Skip to content

refactor(settings): migrate the account management section to Vue 3 - #66523

Merged
pringelmann merged 3 commits into
masterfrom
refactor/settings-account-management-vue3
Nov 16, 2026
Merged

pringelmann merged 3 commits into
masterfrom
refactor/settings-account-management-vue3

Conversation

@pringelmann

@pringelmann pringelmann commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Migrates the account management section to Vue 3

Easiest to review commit by commit: E2E tests first, then a pure move, then the migration.

Also fixes a few things that are broken on master too:

  • Welcome email switch and default quota stay changed when saving fails, now they roll back with an error
  • Changing the default quota doesn't update accounts on "default" quota until reload
  • Cancelling the password dialog on delete / wipe throws
  • Cancelling the password dialog when editing an account shows "Failed to update account"
  • Failed group creation shows two error toasts
  • Group names with & show as & in the heading

Manually tested

  • Navigation: all accounts, admins, recent, disabled, groups, back button, deep links
  • Groups: create, rename, delete, search, loading more on scroll
  • Accounts: search, loading more on scroll, new account, edit, delete and wipe
  • Settings dialog: column toggles, group sorting, welcome email, default quota

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@pringelmann pringelmann self-assigned this Nov 11, 2026
@pringelmann pringelmann added technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 11, 2026
@pringelmann
pringelmann force-pushed the refactor/settings-account-management-vue3 branch 2 times, most recently from fdec09e to a60ce60 Compare November 13, 2026 13:17
@github-actions

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
8 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 8 queries added
  - UPDATE "oc_filecache" SET "size" = :dcValue4 WHERE ("fileid" = :dcValue1) AND ("storage" = :dcValue2) AND (("size" <> :dcValue3) OR ("size" IS NULL))
  - UPDATE "oc_filecache" SET "size" = :dcValue4 WHERE ("fileid" = :dcValue1) AND ("storage" = :dcValue2) AND (("size" <> :dcValue3) OR ("size" IS NULL))
  - SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
  - SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
  + SELECT "storage", "path", "mimetype" FROM "oc_filecache" WHERE "fileid" = :dcValue1
  + SELECT "storage_id", "root_id", "user_id", "mount_point", "mount_id", "f"."path", "mount_provider_class" FROM "oc_mounts" "m" INNER JOIN "oc_filecache" "f" ON "m"."root_id" = "f"."fileid" WHERE ("m"."storage_id" = :dcValue1) AND ("f"."storage" = :dcValue2) AND (("f"."fileid" = :dcValue3) OR ("f"."path" = '') OR (("f"."path" || :dcValue4) = SUBSTR(:dcValue5, :dcValue6, LENGTH("f"."path") + :dcValue7))) AND ("user_id" = :dcValue8)
  + SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "filecache"."etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE ("filecache"."fileid" = :dcValue1) AND ("storage" = :dcValue2)
  + DELETE FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
  + DELETE FROM "oc_filecache_extended" WHERE "fileid" = :dcValue1
  + SELECT "file_id", "json", "sync_token" FROM "oc_files_metadata" WHERE "file_id" IN (:dcValue1)
  + SELECT "file_id", "json", "sync_token" FROM "oc_files_metadata" WHERE "file_id" IN (:dcValue1)
  + DELETE FROM "oc_files_metadata" WHERE "file_id" IN (:dcValue1)
  + DELETE FROM "oc_files_metadata_index" WHERE "file_id" IN (:dcValue1)
  + SELECT "fileid" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("path_hash" = :dcValue2)
  + UPDATE "oc_file_locks" SET "lock" = :dcValue1, "ttl" = :dcValue2 WHERE ("key" = :dcValue3) AND ("lock" = :dcValue4)
  + SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "filecache"."etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE ("path_hash" = :dcValue1) AND ("storage" = :dcValue2)
= ./occ profiler:list

@pringelmann pringelmann added the 3. to review Waiting for reviews label Nov 13, 2026
@pringelmann pringelmann added this to the Nextcloud 36 milestone Nov 13, 2026
@pringelmann
pringelmann marked this pull request as ready for review November 13, 2026 13:21
@pringelmann
pringelmann requested review from a team as code owners November 13, 2026 13:21
@pringelmann
pringelmann requested review from artonge, icewind1991, kristian-zendato, salmart-dev, skjnldsv and susnux and removed request for a team, icewind1991 and salmart-dev November 13, 2026 13:21
@pringelmann pringelmann changed the title test(settings): cover account management navigation and settings refactor(settings): migrate the account management section to Vue 3 Nov 13, 2026

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would maybe even make this its own app similar to appstore (account_management) to split separated concerns here.
But for refactoring only this is very good :)

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the refactor/settings-account-management-vue3 branch from a60ce60 to b632b1f Compare November 16, 2026 08:24
@pringelmann
pringelmann merged commit 03e6cb7 into master Nov 16, 2026
156 of 158 checks passed
@pringelmann
pringelmann deleted the refactor/settings-account-management-vue3 branch November 16, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted feature: settings feature: users and groups ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants