Repository navigation
refactor(settings): migrate the account management section to Vue 3 - #66523
Merged
Merged
Conversation
pringelmann
force-pushed
the
refactor/settings-account-management-vue3
branch
2 times, most recently
from
November 13, 2026 13:17
fdec09e to
a60ce60
Compare
Contributor
|
Possible performance regression detected Show Output |
pringelmann
marked this pull request as ready for review
November 13, 2026 13:21
pringelmann
requested review from
artonge,
icewind1991,
kristian-zendato,
salmart-dev,
skjnldsv and
susnux
and removed request for
a team,
icewind1991 and
salmart-dev
November 13, 2026 13:21
susnux
approved these changes
Nov 13, 2026
susnux
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I would maybe even make this its own app similar to appstore (account_management) to split separated concerns here.
But for refactoring only this is very good :)
benjaminfrueh
approved these changes
Nov 16, 2026
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
refactor/settings-account-management-vue3
branch
from
November 16, 2026 08:24
a60ce60 to
b632b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the account management section to Vue 3
Easiest to review commit by commit: E2E tests first, then a pure move, then the migration.
Also fixes a few things that are broken on master too:
&show as&in the headingManually tested
Checklist
3. to review, feature component)stable32)AI (if applicable)