Repository navigation
fix(test): drive the Compose settings screen in LoginIT - #7066
Merged
Merged
Conversation
Contributor
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
AndyScherzinger
force-pushed
the
fix/login-it-compose-settings
branch
from
November 19, 2026 09:52
dbbf345 to
8bc4538
Compare
The settings screen moved to Compose in 915a966, which removed the view R.id.settings_remove_account. LoginIT still referenced it, so the androidTest sources no longer compiled and every instrumented test run failed. Removing a leftover account and checking the logged-in user now go through a Compose test rule: open the account chooser from the avatar, open the settings, remove the account and confirm, and look for the user's display name in the account chooser. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
fix/login-it-compose-settings
branch
from
November 20, 2026 14:05
8bc4538 to
966b005
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instrumented tests (
test (master, 29)) fail to compile on master since the settings screen moved to Compose in #7055:LoginITstill clicksR.id.settings_remove_account, which no longer exists.LoginITnow uses a Compose test rule for the parts of the UI that are Compose: it opens the account chooser from the avatar, opens the settings, removes a leftover account and confirms, and at the end looks for the user's display name in the account chooser.The test stays
@Ignored as before; this only makes the androidTest sources compile again, so the other instrumented tests run.🖼️ Screenshots
🚧 TODO
./gradlew :app:compileGplayDebugAndroidTestJavaWithJavacpasses🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)