Skip to content

fix(test): drive the Compose settings screen in LoginIT - #7066

Merged
AndyScherzinger merged 1 commit into
masterfrom
fix/login-it-compose-settings
Nov 20, 2026
Merged

AndyScherzinger merged 1 commit into
masterfrom
fix/login-it-compose-settings

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

The instrumented tests (test (master, 29)) fail to compile on master since the settings screen moved to Compose in #7055: LoginIT still clicks R.id.settings_remove_account, which no longer exists.

LoginIT now uses a Compose test rule for the parts of the UI that are Compose: it opens the account chooser from the avatar, opens the settings, removes a leftover account and confirms, and at the end looks for the user's display name in the account chooser.

The test stays @Ignored as before; this only makes the androidTest sources compile again, so the other instrumented tests run.

🖼️ Screenshots

🏚️ Before 🏡 After
n/a (test only) n/a (test only)

🚧 TODO

  • ./gradlew :app:compileGplayDebugAndroidTestJavaWithJavac passes

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger AndyScherzinger added this to the 26.0.0 milestone Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 966b005
Version 7066
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Nov 19, 2026
@AndyScherzinger
AndyScherzinger force-pushed the fix/login-it-compose-settings branch from dbbf345 to 8bc4538 Compare November 19, 2026 09:52
The settings screen moved to Compose in 915a966, which removed the
view R.id.settings_remove_account. LoginIT still referenced it, so the
androidTest sources no longer compiled and every instrumented test run
failed.

Removing a leftover account and checking the logged-in user now go
through a Compose test rule: open the account chooser from the avatar,
open the settings, remove the account and confirm, and look for the
user's display name in the account chooser.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the fix/login-it-compose-settings branch from 8bc4538 to 966b005 Compare November 20, 2026 14:05
@github-actions

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings1716
Errors00

SpotBugs

CategoryBaseNew
Bad practice77
Correctness88
Dodgy code4040
Internationalization33
Malicious code vulnerability33
Performance77
Security1111
Total7979

@AndyScherzinger
AndyScherzinger merged commit ef60195 into master Nov 20, 2026
19 of 21 checks passed
@AndyScherzinger
AndyScherzinger deleted the fix/login-it-compose-settings branch November 20, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant