Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ jobs:
name: pypi
url: https://pypi.org/p/python-json-logger
permissions:
contents: read
# GitHub only lists draft releases for callers with push access.
contents: write
id-token: write
steps:
# Only the reviewed release helper is needed; preflight uses no third-party packages.
Expand Down
3 changes: 2 additions & 1 deletion docs/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ The approved job uses OIDC to upload the complete distribution set. It checks ou
only `scripts/release.py` at the run's commit without persisting checkout credentials.
The shared Python checks run with isolation enabled and use only the standard
library. A separate finalization job verifies both PyPI filenames and hashes before
publishing the original draft.
publishing the original draft. The approved job needs `contents: write` because
GitHub requires push access to list draft releases and inspect their assets.
Keep the Trusted Publisher repository, workflow filename `release.yml`, and
`pypi` environment unchanged.

Expand Down
Loading