Skip to content

chore: update messages on automated/official PRs - #2665

Open
nschonni wants to merge 1 commit into
nodejs:mainfrom
nschonni:pr-body-updates
Open

nschonni wants to merge 1 commit into
nodejs:mainfrom
nschonni:pr-body-updates

Conversation

@nschonni

Copy link
Copy Markdown
Member

Description

Adds the pointers/messages about the Docker Image release cycle to the body of the PRs.

Motivation and Context

Probably won't prevent the "why isn't this available" comments we often get, but having it in the body means it's less likely to ge folder/hidden if people come to the actual PRs to comment.

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni
nschonni requested a review from a team October 21, 2026 20:25
issue-number: ${{ github.event.pull_request.number }}
body: |
Created PR on the official-images repo (${{ steps.create-pr.outputs.pull-request-url }}). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.
Created PR on the official-images repo (${{ steps.create-pr.outputs.pull-request-url }}).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to remove this link.

base: main
commit-message: 'feat: Node.js ${{ steps.updt.outputs.result }}'
title: 'feat: Node.js ${{ steps.updt.outputs.result }}'
body: 'Before commenting to ask when this will be available, see the [README](https://github.com/nodejs/docker-node#release-availability)'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have worded this a bit differently, but that's more of a style question.

"If you are reading this PR soon after it has been merged, you may find that new Docker images are missing or appear broken. Check back later and see the README for background information."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to suggest the wording, I don't really feel strongly about the words I used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants