Repository navigation
Conversation
Per RFC 9112 section 6.3, responses to HEAD requests, and 204 and 304 responses, cannot contain a message body. When such a response is complete and nobody has started reading it, release its socket back to the agent's free pool instead of waiting for an 'end' that only a reader can cause. Refs: nodejs#47228 Assisted-by: claude:sonnet-5.5 Signed-off-by: Matt Weber <hello@mweber.xyz>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HEAD requests and 204/304 status code responses cannot have a message body per RFC 9112, section 6.3.
This commit ensures that an http response that cannot have a body does not end up tying up the socket or keepalive pool.
This PR supersedes #52329, which I left long orphaned (apologies) and had flaws that change behavior of existing code in small ways (ordering of events, side effects).
Tests
The new test sends unconsumed HEAD, 204 and 304 requests through a keep-alive agent and checks that the process exits without hanging.
The test was extracted from the previous PR unchanged (except for the addition of comments) to ensure the new approach matches the behavior of the previous implementation. @aduh95 pushed a fix to my original tests, let me know if you would like me to add a Co-authored-by trailer to this commit.
AI assistance
Claude Code was used to identify flaws in the original approach, add comments to the test file, and verify the robustness of the implementation.