Repository navigation
Conversation
node_ffi_fast_buffer_data() runs inside a V8 Fast API call, where no HandleScope is open. ArrayBufferView::Buffer() created a Local on every optimized call, which accumulated in the caller's scope until the current synchronous run ended. Open one HandleScope for the whole helper, matching Node's other fast callbacks. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66867 +/- ##
==========================================
- Coverage 90.51% 90.50% -0.02%
==========================================
Files 797 797
Lines 278221 278213 -8
Branches 53463 53458 -5
==========================================
- Hits 251844 251790 -54
- Misses 16763 16799 +36
- Partials 9614 9624 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66866
node_ffi_fast_buffer_data()runs inside a V8 Fast API call, where noHandleScopeis open. It callsArrayBufferView::Buffer(), which created aLocalin the caller's scope on every optimized call. Over 2e7 calls, RSS grew from 50 MB to 675 MB.This opens one
HandleScopefor the whole helper, matching Node's other fast callbacks. The new test usesv8.queryObjects()to check that optimized calls don't keep backing stores alive.Assisted-by: claude:opus-5.5