Skip to content

crypto: fix BoringSSL RSA-PSS macro redefinitions - #66900

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:fix-boringssl-warnings
Oct 21, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:fix-boringssl-warnings

Conversation

@panva

@panva panva commented Oct 21, 2026

Copy link
Copy Markdown
Member

See the BoringSSL build failure. Include <openssl/rsa.h> before defining the fallback RSA-PSS constants. Previous rounds: #66752 and #66889.

@panva
panva requested a review from aduh95 October 21, 2026 13:49
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 21, 2026
@panva

panva commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

Requesting a fast-track given the change is trivial, and would unblock #66751 before more warnings are introduced.

@panva panva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2026
@panva panva removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva force-pushed the fix-boringssl-warnings branch from d243f4d to 1b70acb Compare October 21, 2026 13:53
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2026
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.59%. Comparing base (39e03b4) to head (1b70acb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66900      +/-   ##
==========================================
+ Coverage   90.57%   90.59%   +0.02%     
==========================================
  Files         797      797              
  Lines      278502   278502              
  Branches    53540    53549       +9     
==========================================
+ Hits       252247   252317      +70     
+ Misses      16592    16528      -64     
+ Partials     9663     9657       -6     
Files with missing lines Coverage Δ
src/node_constants.cc 99.71% <ø> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 14ed05f into nodejs:main Oct 21, 2026
83 of 84 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 14ed05f

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2026
@panva
panva deleted the fix-boringssl-warnings branch October 21, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants