Repository navigation
chore(deps): update devdependency knip to v6.42.1 - #3345
Conversation
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @cylewaitforit. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title names the main change: a devDependency update of knip to v6.42.1. The changeset also removes unused exports and an unused component, which the title does not mention, but the title is accura… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The description directly matches the changes. It explains the Knip 6.42.1 update, the removal of unused code, and the deletion of an unused file. |
Full details: Title check
-
Explanation
The title names the main change: a devDependency update of knip to v6.42.1. The changeset also removes unused exports and an unused component, which the title does not mention, but the title is accurate and specific to the primary change. Scope is conventional-commit style with a clear subject.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📊 Dependency Size ChangesWarning This PR adds 234.2 kB of new dependencies, which exceeds the threshold of 200 kB.
Total size change: 234.2 kB |
gameroman
added
the
needs review
|
unused i18n keys will also need to be removed then |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
94f9d37 to
22c5f49
Compare
Thanks @gameroman, I ran the i18n report fix script but touching those files caused the autofix workflow to create empty translation keys. I've moved that autofix commit to a separate PR (#3349) since the changes aren't actually related to this knip update. |
86fc870 to
f2c2ec8
Compare
Note
The commit for #3349 was originally generated by the autofix pipeline in this PR.
Why not stack the PRs?
PRs from forks are not currently supported by GH stacks. That would have required the fix-i18n-empty-keys branch to be part of the parent repo instead of the fork. github/gh-stack#46
🔗 Linked issue
#3306
🧭 Context
This updates to knip 6.42.1 and runs knip:fix.
Then removed code determined by knip to be unused.
Also removed file marked as unused. It hasn't been used for over 7 months and since it was part of the source control it can always be restored if it is needed.
📚 Description
Knip 6.39.0 allowed Knip to skip synthetic self-imports in Vue and Nuxt auto-import compilers. Before these exports looked used even though nothing else imported them.