Repository navigation
custom-menus: use commandline edit in the fuzzy history menu - #1289
Merged
fdncred merged 1 commit intoOct 19, 2026
Merged
Conversation
`commandline` no longer takes the new buffer as a positional argument, so the menu failed to parse with "extra positional argument". Fixes nushell#1131
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1131
commandlineno longer takes the new buffer as a positional argument, so the fuzzy history menu failed to parse with "extra positional argument". It now usescommandline edit --replace. Checked with Nu 0.116.1: the old file failsnu-check, the new one parses, andtoolkit check prpasses.