Skip to content

docs(adr): ADR-0011 says the identity census covers twelve identity objects; the tree has thirteen since the 2026-11-07 SCIM amendment #31621

Closed

Description

@objectstack-fleet

domain:skills#3 · zhuangjianguo · session_01QsR2jULfPnqQFGcZUtKDFH

Filing gate: (b) a follow-up a review names. Contract review 6724527824 on PR #31616 (card #31452), ④ nit, outside that PR's diff. ⛔ Not a claim.

维护者速读

ADR-0011 的身份动作评估段说评估覆盖了 packages/platform-objects/src/identity/ 里「十二个」身份对象。2026-11-07 的修订把 sys_scim_connection_credential 的两个动作也收进了评估,现在带动作的身份对象是 13 个。这句话读起来像现在的清点,其实停在了修订之前。只改一个词,不涉及任何评估。

What

  • docs/adr/0011-actions-as-ai-tools.md L317-318 (on main 133f75a): "The named actions on the twelve identity objects in packages/platform-objects/src/identity/ were assessed once, as one set".
  • Measured by the review on the live tree: 13 action-bearing objects under that directory, the 13th being sys_scim_connection_credential, whose two actions came with the 2026-11-07 amendment (the ADR's own census paragraph, L375-376).

Ask

  • Either say thirteen and note the amendment, or make the sentence explicitly historical ("twelve at the 2026-10-30 assessment"). Pick by reading the paragraph whole. Tier H (docs/adr/**).

Not in scope

  • Assessing sys_user.list_platform_admins or sys_sso_provider.edit_sso_sign_in_options (a maintainer ruling).

Related: #31452, PR #31616.

Activity

  1. added
    documentationImprovements or additions to documentation
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Nov 8, 2026
  2. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: domain:server · p3 · pm:queue · 2026-11-08T17:52Z

    ⛔ Not a claim.


    Generated by Claude Code

  3. added
    domain:serverDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    pm:queueReady for the PM dispatch loop
    on Nov 8, 2026
  4. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#4 · os-steve · session_01ADHkmP8JJo4zF2sjTBRwnX

    Claim: PM loop round 1 · #31621 · 2026-11-08T18:56Z
    Session: session_01ADHkmP8JJo4zF2sjTBRwnX (seat); dev = card thread session_01ADHkmRbRXBo8uDXg21xy8x
    Account: os-steve
    Branch: claude/project-thread-5le3u1
    Worktree: the card thread's checkout of objectstack-ai/objectstack
    Domain: domain:server
    Seat: domain:server#4
    File surface: docs/adr/0011-actions-as-ai-tools.md, the one "twelve identity objects" sentence only (stop on breach). Governed surface: the PR stays draft until a GOVERNED_APPROVERS approval; Tier H.
    Container & model: S, mode:thread, model: default tier (governed rules text: the contract review is owed at CONTRACT_REVIEW_TIER before hand-off), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card
    Thread-read: 6724973471
    Premise: holds (re-measured by the dev in step 0: the action-bearing object count under packages/platform-objects/src/identity/)
    Serial constraints cleared: open draft PR #31616 (#31452, domain:skills#3) edits the same ADR file; this card lands after it (Notify: serial sent to domain:skills#3); the dev merges origin/main once #31616 lands.

  5. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#4 · os-steve · session_01ADHkmRbRXBo8uDXg21xy8x
    os-dev-report

    {
      "issue": 31621,
      "status": "done",
      "branch": "claude/project-thread-5le3u1",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/31648",
      "session": "session_01ADHkmRbRXBo8uDXg21xy8x",
      "premise_still_valid": true,
      "summary": "Premise measured on origin/main 99364ea7: 13 objects under packages/platform-objects/src/identity/ declare an actions array (sys_account, sys_api_key, sys_invitation, sys_member, sys_oauth_application, sys_organization, sys_scim_connection_credential, sys_session, sys_sso_provider, sys_team_member, sys_team, sys_two_factor, sys_user); no other actions spelling. ADR-0011's addendum sentence now dates the twelve to the 2026-10-30 assessment and names the thirteenth, sys_scim_connection_credential, brought in by the 2026-11-07 amendment. One sentence, no other paragraph, no action assessed. Draft PR #31648 (Tier H, stays draft).",
      "tests": "Docs-only diff; no package touched, so no build/test/typecheck owed and no ablation (docs are not ablated). Premise count: grep for an actions array over every identity *.object.ts at 99364ea7 = 13 files; a second grep for any other actions spelling = 0 hits.",
      "gates": "dispatch-gates --commands at head 20a1c07d: 21 derived, 21 run, all exit 0 (check-adr-links + self-test, closing-keyword-parity + self-test, comment-mask-corpus, plan-test-core-shards self-test, lint check:doc-formula-expressions, adr-anchors, adr-index, adr-symbol-anchors, ci-filter-parity, closed-ceremony-text, cross-package-test-inputs, doc-authoring, driver-memory-census, gitlink-declared, nul-bytes, pm-governed-merges, pm-prior-rulings, refd-timer-probe, watch-hint-literal). check:doc-formula-expressions first exit 3 (formula/lint dist absent, nothing measured), green after building those two under os-verify-lock (VERDICT command-exit 0). --ran: 21 derived, 21 run, 0 NOT-MEASURED, 0 UNRUN. pnpm lint: n/a, no package touched. CI check-runs: in_progress at report time.",
      "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
      "mcp_calls": "6 — issue_read x3 (get, get_comments x2), pull_request_read x3 (get_comments 31616, get 31648, get_check_runs 31648); no write tools",
      "api_writes": "2 — fleet relay pr_create (PR #31648, labels skip-changeset); this report comment via post-stamped",
      "open_questions": [
        { "question": "Which spelling for the sentence?", "options": ["A historical twelve dated to 2026-10-30 plus the thirteenth named (taken)", "B say thirteen and note the amendment", "C historical twelve only"], "recommendation": "A, because the sentence also says assessed once, as one set, which is true only of the 2026-10-30 twelve; A keeps that true and still gives the current count." }
      ],
      "security_findings": "none",
      "out_of_scope_findings": [],
      "files_changed": ["docs/adr/0011-actions-as-ai-tools.md"],
      "line_budget": "+4 / -2, 1 file (claim surface: the one sentence)",
      "deviations": ["PR opened with no assignee: the actions file sent no assignees key; the seat may set Account os-steve.", "Open PR #31616 edits the same file in other paragraphs; per the delta, origin/main is merged again after it lands, landing order is the seat's."]
    }

    Stamped 2026-11-08T19:06Z.

  6. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#4 · os-steve · session_01ADHkmP8JJo4zF2sjTBRwnX

    Landed · #31621 · 2026-11-08T21:43Z

    Probe Reading
    PR #31648 merged through the queue 2026-11-08T21:42:55Z as a2d0f737a8; head 20a1c07d42 (ACCEPT 6725902836); Tier H governed (docs/adr/**), readied and enqueued by GOVERNED_APPROVER os-zhuang
    #31621 closed by Fixes #31621

    State change: pm:dispatched removed and os-steve unassigned in this stroke. No follow-up card is owed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:serverDomain lane — seat card indexed by label:pm:seatpriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions