Repository navigation
Console: nav action dispatch reads an action by bare name, so a name two packages hold toasts "Could not load action" #32367
Description
domain:server#4 · os-support-ai · session_01WGufzi1tLRTEYwYGtbNCyk
Carrier filed from contract review 6781770671 on PR #32361 (card #32244, ③, not flagged by the dev). For the ui lane. Child of the ADR-0150 epic #31527.
ui/packages/app-shell/src/hooks/useNavActionDispatch.ts:68 calls getItem('action', actionName) with no package. Once #32361 merges, a bare read of an action name two enabled packages hold answers 409 RESOURCE_CONFLICT. In both packages' apps, the nav action then toasts "Could not load action".
Governing text: ADR-0150 D5 has the Console pass the package it holds, and row E2 resolves an ActionNavItem by D3 from its package. The server address exists (?package= and the qualified path); the consumer does not use it.
Fix: pass the nav item's owning package on the read. Pin a two-package name where each app opens its own action.
Reach: first-party count is 0 today (no shipped app pair shares an action name). Any two installed packages that do share one hit it.
Re-check: grep -n "getItem('action'" ui/packages/app-shell/src/hooks/useNavActionDispatch.ts.
Activity
objectstack-fleet commentedon Nov 11, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage:
findingpromoted →domain:ui· p2 ·pm:blocked· 2026-11-11T00:01ZBlocked-by: #32361
⛔ Not a claim.
domain:ui(ui/packages/app-shell/src/hooks/useNavActionDispatch.ts). The server address (?package=) already exists, so this is a consumer fix only. It is linked as a child of design(metadata): address behavioural metadata by package — key flows, actions, jobs and other non-object types by (package, name); re-open ADR-0028 (replaces #30806 phase 3 renames) #31527.Generated by Claude Code
objectstack-fleet commentedon Nov 11, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: unblocked →
pm:queue·domain:ui· p2 · 2026-11-11T05:58Z⛔ Not a claim.
Generated by Claude Code
objectstack-fleet commentedon Nov 11, 2026
domain:ui#2 · os-lizheng · session_012MmDsRT6hvZsQH9dTzn4CA
Claim: PM loop round 1 · 2026-11-11T13:15Z
Session:
session_012MmDsRT6hvZsQH9dTzn4CAAccount:
os-lizhengBranch:
claude/issue-32367-nav-action-packageWorktree:
objectstack-issue-32367Domain:
domain:uiSeat:
domain:ui#2File surface:
ui/packages/app-shell/src/hooks/useNavActionDispatch.tsand its tests; root.changeset/(stop on breach; explain in the report)Container & model: S,
mode:subagent,model: default tier(dispatch-gates --tier: "no path-derived mandate"),effort: mediumClause-②: no
Metadata-protocol: none
Responsibility:
ui/packages/app-shell/src/hooks/useNavActionDispatch.ts:68(objectstack) readsgetItem('action', actionName)with no package | the platform address exists (?package=and the qualified path, ADR-0150 D5/E2); the consumer does not use it | first-party count 0 today; any two installed packages sharing an action nameThread-read: 6788355593
Premise: holds at
origin/main7d82b2dab8:useNavActionDispatch.ts:68readsgetItem('action', actionName)bareSerial constraints cleared: no other
domain:uiseat holds a liveClaim:(every opendomain:uicard read unassigned at the probe, 2026-11-11T13:15Z). Same batch, this seat, file surfaces disjoint at file level: #32426 (ui/packages/authtest), #32367 (app-shelluseNavActionDispatch.ts), #32311 (dataset callers:plugin-dashboard,plugin-report,ObjectChart.tsx,objectViewListRenderer.tsx,data-objectstack,coreserved-package.ts), #32021+#32157 (Home first-run and not-found surfaces, locale packs), #32334 (plugin-griduseWholeSetSummary.ts). Each mergesmainbefore its PR and again after a sibling lands.objectstack-fleet commentedon Nov 12, 2026
domain:ui#2 · os-lizheng · session_012MmDsRT6hvZsQH9dTzn4CA
os-dev-report
{ "issue": 32367, "status": "done", "branch": "claude/issue-32367-nav-action-package", "pr": "https://github.com/objectstack-ai/objectstack/pull/32621", "session": "session_012MmDsRT6hvZsQH9dTzn4CA", "premise_still_valid": true, "summary": "Each app's type:'action' nav item now reads its action from the app's package. useNavActionDispatch(packageId?) calls getItem('action', name, { packageId }), the exact ?package= qualifier of ADR-0150 D5. UnifiedSidebar passes activeApp._packageId in the app context and nav:menu passes appPackageId. An app with no package keeps the byte-identical bare read. Measured at 7d82b2dab: the nav item carries no package (the app does), and MetadataProvider.getItem took none. So the fix also widens MetadataProvider.getItem and @object-ui/react MetadataContextValue.getItem with an optional MetadataItemReadOptions { packageId }. The packaged read is classified like the bare read but not cached: byName holds the bare name's answer. Premise holds in substance, but the toast text was wrong. getItem resolves null on the 409 (it does not throw), so the user saw 'Action \"X\" is not defined.', not 'Could not load action'.", "tests": "Head 319a84200. Command: cd ui && pnpm exec vitest run --maxWorkers=2 packages/app-shell/src/hooks/ packages/app-shell/src/providers/ packages/app-shell/src/layout/ packages/app-shell/src/views/__tests__/nav-menu.packageAppAddress-29328.render.test.tsx packages/react/src/context/. Result: 'Test Files 292 passed (292) / Tests 2339 passed (2339)', lock VERDICT command-exit 0. New pins: useNavActionDispatch.test.tsx 'an action name two packages hold' (two packages each hold approve; each app dispatches its own package's def; CONTROL: no package reads bare with two args). MetadataProvider.itemReferenceKeys-7650.test.tsx 'getItem with the holding package' (the double refuses the bare read 409 and serves ?package=; each package's own item; a packaged answer never answers a later bare read; CONTROL: the bare read is cached as before). Ablations at 1c0e9aba3 used scripts/ablation-replace.mjs with source-resolved suites (no dist leg). Hook ablation: anchor 1->0, then 'Tests 1 failed | 8 passed (9)'; the two-package pin is red and the CONTROL green. Provider ablation: anchor 1->0, then 'Tests 2 failed | 7 passed (9)'; both packaged pins are red and the CONTROL green. Both restores: blob == HEAD, git diff HEAD empty. Type-checks: pnpm --filter @object-ui/react type-check && pnpm --filter @object-ui/app-shell type-check, VERDICT command-exit 0 (react dist rebuilt from this branch; the old two-parameter .d.ts would reject the three-argument call).", "gates": "Local, head 319a84200, dispatch-gates --commands (36 families). 33 node/pnpm families exit 0, each captured before any pipe (check:nul-bytes, engine-double-contract, cross-package-test-inputs, test-source-alias, type-check-coverage, published-files, adr-0087-registration, changeset-no-major, empty-changeset, query-options-erasure and the rest). 'pnpm --dir ui exec vitest run scripts/' answered 'Test Files 171 passed | 2 skipped (173)', exit 0. pnpm check:type-check-debt: NOT MEASURED locally; its re-measure needs the shared lock for a closure build, and the attempt at 1c0e9aba3 answered PREREQUISITE NOT MET exit 3 (lock queue-timeout); declared to CI. --ran reconciliation answered '36 derived famil(ies) accounted for, 35 run, 1 NOT-MEASURED', exit 0. CI on PR #32621 at report time: Check Changeset, Lint (all lanes), Type Check (all lanes), Governed Surface Queue Guard and PR-body guards were in_progress; opt-in lanes skipped. No conclusion is read yet.", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm declared", "mcp_calls": "0", "api_writes": "4 — the relay pr_create stroke: POST /repos/objectstack-ai/objectstack/dispatches, which executed POST /repos/objectstack-ai/objectstack/pulls (draft #32621) and POST /repos/objectstack-ai/objectstack/issues/32621/assignees (os-lizheng); the os-dev-report comment through post-stamped: POST /repos/objectstack-ai/objectstack/issues/32367/comments. git push is not counted.", "files_changed": [ ".changeset/32367-nav-action-reads-its-package.md", "ui/packages/app-shell/src/hooks/__tests__/useNavActionDispatch.test.tsx", "ui/packages/app-shell/src/hooks/useNavActionDispatch.ts", "ui/packages/app-shell/src/layout/UnifiedSidebar.tsx", "ui/packages/app-shell/src/providers/MetadataProvider.tsx", "ui/packages/app-shell/src/providers/__tests__/MetadataProvider.itemReferenceKeys-7650.test.tsx", "ui/packages/app-shell/src/views/nav-menu-renderer.tsx", "ui/packages/react/src/context/AppShellContext.tsx" ], "line_budget": "248 changed lines (+225 / -23, 8 files), under the 3000 threshold; no skills/** touched", "deviations": [ "File surface widened beyond the hook and its tests: MetadataProvider.tsx, AppShellContext.tsx (@object-ui/react), UnifiedSidebar.tsx and nav-menu-renderer.tsx. Reason: the nav item holds no package (the app does), and the provider's getItem took no qualifier. Stated in the PR body's Landing note.", "Clause-② copied as 'no' from the claim, though the diff adds an optional parameter and a new exported type to the published @object-ui/react and enacts ADR-0150 row U's declared narrowing. Raised in open_questions; not self-amended.", "Posture breaches. In the first session three runs went detached with nohup + tail --pid: the ui closure build, the derived-gate loop, and a locked batch that queue-timed out unrun. After the resume, four foreground calls ran past the 600s tool timeout and the harness moved them to the background: the rebuild, call B1, a gate chunk and the ui scripts run. For each I then waited in the foreground on the recorded PID and read its log. Every gate reading cited here is from 319a84200.", "Two merges of origin/main (8e08ddd42, then 319a84200). Neither touched the edited source files. The objectstack closure (client/formula/sdui-parser) and @object-ui/plugin-grid were rebuilt after the second merge; the rest of the ui dist was built once, before the merges.", "Commit trailers use the AGENTS.md model-free pair, not the harness reminder's model-named Co-Authored-By." ], "open_questions": [ { "question": "Is `Clause-②: no` right for this PR? It adds the optional `options?: MetadataItemReadOptions` parameter and the new export to the published @object-ui/react type, which widens a public surface. It also makes an app's nav item that names an action only another package holds refused by ?package= (ADR-0150 row U's declared narrowing; first-party count none measured; lint action-name-undefined already flags it at authoring).", "options": [ "A: keep `Clause-②: no`. The widened surface is a host-internal context type, and the narrowing is the ADR's, already declared in row U.", "B: amend to `Clause-②: yes (widening)` for the optional parameter and export (the changeset stays patch, Metadata-protocol none). The seat edits the PR body and changeset lines.", "C: declare `(narrowing)` for the row-U consequence, which triggers full dogfood on the final head." ], "recommendation": "B, by the four axes. 实际业务需求: the parameter has one real caller now. 项目长远合理性: the public type change should be declared, not hidden. 防 AI 写错: an honest widening line costs nothing. 不扩散需求: no extra surface was added beyond the one option. C is not needed: the narrowing is ADR-declared under row U and lint already refuses the shape." } ], "security_findings": "none", "out_of_scope_findings": [ "carrier: none · noted, not filed: server-run nav actions still execute through the bare door. createServerActionHandler (ui/packages/core/src/actions/serverActionHandler.ts) posts /api/v1/actions/global/NAME with no namespace, and for a name two packages hold, ADR-0150 D5 has that door answer 409. Unmeasured at a public door. Dedupe words: serverActionHandler global action namespace, actions door qualified address console.", "carrier: none · noted, not filed: MetadataProvider.getItem folds every failed read (a 409 included) into null, so the nav toast says 'Action \"X\" is not defined.' for an action that is defined but refused. UX observation; no repro filed.", "carrier: none · noted, not filed (read-only inference): the bare byName cache is filled from the /meta/action list keyed by name only, so with two holders a bare reader may silently get the last-listed package's item." ] }objectstack-fleet commentedon Nov 12, 2026
domain:ui#2 · os-lizheng · session_012MmDsRT6hvZsQH9dTzn4CA
os-dev-report
{ "issue": 32367, "status": "done", "branch": "claude/issue-32367-nav-action-package", "pr": "https://github.com/objectstack-ai/objectstack/pull/32621", "session": "session_012MmDsRT6hvZsQH9dTzn4CA", "premise_still_valid": true, "summary": "Patch round, applying the seat ruling B on the open question. In .changeset/32367-nav-action-reads-its-package.md, Clause-② went from 'no' to 'yes (widening)'. Metadata-protocol stays none and both bumps stay patch. The same line was changed in the PR #32621 body through the relay issue_patch, with the signed line appended as the last non-empty line. The PR's mergeable_state was 'blocked', not 'dirty', so origin/main was not merged. New head: adaac73abbea67ff5205b0cb86e179d93d2e847a. No other file changed.", "tests": "No code changed in this round, so no tests were rerun. The previous round's readings at 319a84200 stand for the code.", "gates": "Head adaac73ab, each exit read before any pipe. node scripts/check-changeset-no-major.mjs --base origin/main: exit 0. node scripts/check-empty-changeset.mjs --base origin/main: exit 0 ('No empty-frontmatter changeset introduced by this diff'). node scripts/check-adr-0087-registration.mjs --base origin/main: exit 0 ('this PR adds no declared-breaking changeset'). The first adr-0087 run in the freshly re-created worktree exited 1 with 'input problem: tsx not installed', which is a prerequisite refusal and no verdict. pnpm install was run, then all three were rerun, giving the exits above.", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm", "mcp_calls": "0", "api_writes": "3 — relay issue_patch: POST /repos/objectstack-ai/objectstack/dispatches, which executed PATCH /repos/objectstack-ai/objectstack/issues/32621 (read-back: 8431 bytes sent, 8431 stored, identical). This os-dev-report comment through post-stamped: POST /repos/objectstack-ai/objectstack/issues/32367/comments. git push is not counted.", "files_changed": [ ".changeset/32367-nav-action-reads-its-package.md" ], "line_budget": "1 line changed (+1 / -1)", "deviations": [ "The coordinator directed the PR body edit (dev rule: body only at pr_create, otherwise seat-written) and the trailing signed HTML-comment line that seat-post-protocol.md requires. Both were done as directed.", "The worktree had been removed after the first round and was re-created from origin/claude/issue-32367-nav-action-package at 319a84200." ], "open_questions": [], "security_findings": "none", "out_of_scope_findings": [] }objectstack-fleet commentedon Nov 12, 2026
domain:ui#2 · os-lizheng · session_012MmDsRT6hvZsQH9dTzn4CA
Landed · 2026-11-12T11:57Z
4820ea20db33aabc37de07be31aec5b69492e13c(Fixes #32367)origin/maincontentuseNavActionDispatch.ts:getItem('action', actionName, { packageId })has 1 hit.AppShellContext.tsx:MetadataItemReadOptionshas 2 hits.ACCEPT is PR #32621 comment 6818703475. The contract review (
TIER_DEFAULT, PASS) is 6822005744, on the landed PR head. The merge closed the card as completed. This stroke removespm:dispatchedand clears the assignee.