Skip to content

plugin-security: delegated-admin gate follow-ups after #32538 — direct-grant refusal wording, the stale re-stamp leg in directGrantSet, and extra gate pins #32720

Open

Description

@objectstack-fleet

epic:#31527#2 · os-bill · session_01Utp6Ca5UHVBDE3DqQXgJsW

Filing gate: ① carried out of PR #32718 (card #32538): the dev's out-of-scope report 6822788987 and the contract review's non-blocking follow-ups, filed per the maintainer's rule that simple review items go to a follow-up card. Part of #31527 (ADR-0150). ⛔ Not a claim.

维护者速读

Scope

  1. Measure directGrantSet's restamped leg for an insert that names a package, on a name a package and the environment both hold. If it over-refuses, judge the named holder only (same rule as plugin-security: the delegated-admin gate refuses an organization administrator who names one of two holders of a permission set #32538) and declare FROM → TO. Fix the stale re-stamp comment either way.
  2. Reword the direct-grant refusal sentence so it matches the seam after feat(plugin-security, runtime, core)!: the permission-set grant, clone and activation doors take a package, and a grant is unique per package #32306.
  3. Pins (plugin-security delegated-admin-gate.test.ts): a named non-holder beside one outside holder is refused; a non-string column; a mixed batch.
  4. A comment nit: the grant leg's new comment leans on the seam's refusal; the gate is right without it, so say so.

Clause-②: the claimer measures (item 1 is likely yes (widening) or no). Dedupe (directGrantSet restamped, position cannot resolve): none found.
class: d · type: Task
Grade: p2 proposed.

Activity

  1. objectstack-fleet commented on Nov 12, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · hotlong · session_01Q4EjjMnyLqJdzuktEmRPXH

    Path: none

    Triage: first touch → domain:server · p2 · pm:queue · 2026-11-12T12:45Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. added
    area:accessPermissions that actually hold — RLS/FLS, sharing model, write-path guards
    domain:serverDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    on Nov 12, 2026
  3. objectstack-fleet commented on Nov 14, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#5 · os-elon-musk · session_016WV4czXwx6JtQPvacrzzUw

    Regrade p2 → p3 · W0 of the area-lease pilot (#33059) · 2026-11-14T15:04Z

    Items 2–4 are wording and pins. Item 1 is measured first; if it really over-refuses, a widened security gate is a maintainer decision and gets its own decision card. The maintainer approved the W0 list: 「以上都同意」.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:accessPermissions that actually hold — RLS/FLS, sharing model, write-path guardsdomain:serverDomain lane — seat card indexed by label:pm:seatpm:queueReady for the PM dispatch looppriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions