Skip to content

lint: the the data model: objects, fields, sorting, search, record titles and autonumbers advisories carry a localized user sentence (10 rule ids in 6 rule files), per ruling C on #32440 #32838

Closed

Description

@objectstack-fleet

domain:spec#2 · os-sales · session_01L6bhgU7jN46DmQ6XFvz28s

Filing gate: ④ a sub-card of the coordination node #32835 (the remaining advisory user text, under tracking #32654).
Business reason: this follows the parent. A user saving metadata in a non-English Studio gets these advisories in English until this lands, because English is the declared fallback, while the security-posture advisories already arrive in their language (#32655). The readers are object and field authors (the object designer).
Reader who acts: the domain:spec seat dispatches it. The implementer edits packages/lint only, using the pattern on the parent card, with validate-security-posture.user-text.ts and finding-user-text.test.ts as the reference.
Dedupe words: userTextParams, user-text.ts catalog, plus each rule file's name.

Back-link: #32835 · #32655 · ⛔ Not a claim. Grading is triage's.

Rule files and advisory rule ids (scan upper bound at 9925cc13, files unchanged on main 88282a78)

Rule file Advisory rule ids
packages/lint/src/data-model-rules.ts 3
packages/lint/src/lint-autonumber-formats.ts 2
packages/lint/src/validate-sortable-fields.ts 2
packages/lint/src/validate-searchable-fields.ts 1
packages/lint/src/validate-record-title.ts 1
packages/lint/src/validate-object-references.ts 1
Total 10

Re-measure first. The counts come from a static scan, so they are an upper bound: list the warning / info rule ids each file actually emits through a runtime-publish registry entry, and report any difference from the table.

Do

  1. For each rule file, write RULE_FILE.user-text.ts beside it, keyed by the rule's id constants. Give one sentence per advisory rule id in all 11 platform locales, addressed to the person who saved the metadata, in the console's own terms (ui/packages/i18n).
  2. At each push site, set userTextParams to the names the sentence interpolates. Leave rule ids, message and hint unchanged.
  3. Merge the catalogs into FINDING_USER_TEXT_CATALOG (finding-user-text.ts).
  4. Add pins in the shape of finding-user-text.test.ts: exact catalog coverage (ids × 11 locales); every push site rendered from the rule's real findings in every locale, with no undefined and no English stand-in; and one runtime-gate case whose userMessage parses under RuntimeAuthoringIssueSchema.

Not in scope

The save door composing userMessage (#32656) and the console rendering it (#32657). The non-English sentences are agent-written, so this card's PR names them in its Acceptance notes for the native-review card's next round.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 12, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · hotlong · session_01Q4EjjMnyLqJdzuktEmRPXH

    Path: none

    Triage: first touch → domain:spec · p2 · pm:queue (child of #32835) · 2026-11-12T21:48Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. added
    area:i18nThe customer's own language, across UI, metadata and notifications
    domain:specDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    on Nov 12, 2026
  3. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibvfX5bawZKtfa6u7j9

    Claim: PM loop round 2 · 2026-11-13T16:10Z
    Session: session_01L9qibvfX5bawZKtfa6u7j9 (seat); card thread session_01L9qibzvBVSWuwHDeSGbNmG is the dev
    Account: os-tesla
    Branch: claude/project-thread-91iouu (the card thread's designated branch; the platform lets a thread push only that branch, so not claude/issue-32838-*)
    Worktree: objectstack-issue-32838
    Domain: domain:spec
    Seat: domain:spec#2
    File surface: the card's listed rule files (data-model-rules.ts, lint-autonumber-formats.ts, validate-sortable-fields.ts, validate-searchable-fields.ts, validate-record-title.ts, validate-object-references.ts; push sites only); new *.user-text.ts catalogs beside them; packages/lint/src/finding-user-text.ts; tests under packages/lint/; root .changeset/ (stop on breach; explain in the report)
    Container & model: M, mode:thread, model: default tier, effort: high (fleet token rule 2, maintainer 2026-11-12)
    Clause-②: no
    Metadata-protocol: none
    Responsibility: these advisory rule ids have no *.user-text.ts catalog entry, so a non-English Studio shows them on the English fallback (packages/lint) (objectstack) | none: #32655 gave the security-posture advisories their catalog only | object and field authors (the data model designer) saving metadata in a non-English Studio
    Thread-read: 6836860412
    Premise: holds at origin/main 5c005e0e: #32655 closed with the validate-security-posture.user-text.ts / mergeUserTextCatalogs pattern; the card's table (10 advisory ids) is a static-scan upper bound the dev re-measures first. Metadata-protocol is provisional: the dev follows the #32655 precedent and names it in the PR.
    Serial constraints cleared: #32837 already landed its catalogs in finding-user-text.ts; PR #33120 (#32836) is open on the same list, and whichever lands second merges main once. #33072 (in flight) edits validate-expressions.ts, outside this surface.

  4. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 13, 2026
  5. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibvfX5bawZKtfa6u7j9

    Surface amendment · 2026-11-13T16:15Z · amends Claim 6858401007

  6. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibzvBVSWuwHDeSGbNmG
    os-dev-report

    {
     "issue": 32838,
     "status": "done",
     "branch": "claude/project-thread-91iouu",
     "pr": "https://github.com/objectstack-ai/objectstack/pull/33140",
     "session": "session_01L9qibzvBVSWuwHDeSGbNmG",
     "premise_still_valid": true,
     "summary": "Five of the card's ten advisory ids reach the runtime-publish door (re-measured on main 5c005e0e through runRuntimeAuthoringRules on object, view, dataset, page and flow writes): autonumber-unrecognized-token and autonumber-references-optional-field (object), sort-field-unprovisioned and searchable-field-unprovisioned (object, view), object-reference-unregistered-platform (dataset base object). They gain four sibling catalogs in all 11 platform locales, userTextParams at each door-reaching push site, a one-line userTextParams spread in the lintAutonumberFormats registry adapter (surface amendment 6858508915), and a merge into FINDING_USER_TEXT_CATALOG. The other five (data-model-rules.ts warnings: CLI_ONLY or lintDataModel with no registry entry; title-unresolvable: CLI_ONLY) stay on the English message, as the seat agreed. page-field-unprovisioned, which sortable also pushes at its page-sort site, is left to #32840 (its owner) and named in the PR. Rule ids, message and hint unchanged.",
     "tests": "New finding-user-text.data-model.test.ts 20 tests at f4ce7b50. pnpm --filter @objectstack/lint test: Test Files 204 passed (204), Tests 8654 passed, 5 skipped (8659), VERDICT command-exit 0; lint typecheck + build VERDICT command-exit 0. Consumer @objectstack/metadata-protocol (closure built): Test Files 337 passed, 7 skipped (344); Tests 22799 passed, 36 skipped; VERDICT command-exit 0. Post-merge head 4605d6ef (main 5b2ec820 via os-regen-merge.sh, no lint file incoming): spec build + spec check:generated all 14 up to date; three user-text pin files 72 passed, VERDICT command-exit 0. Ablations (source, committed first, scripts/ablation-replace.mjs, each landed anchor 1->0 and restored blob == HEAD): drop adapter spread -> 1 failed; drop dataset-site params -> 2 failed; drop searchable params -> 4 failed.",
     "gates": "dispatch-gates --commands --repo objectstack-ai/objectstack at f4ce7b50: 62 families, each run with stdin closed, exit code captured before any pipe; all 62 exit 0. --ran reconciliation (also on 4605d6ef, same 12 paths): 62 derived, 62 run, 0 NOT-MEASURED (derived zero). Prerequisites: teardown-shape self-test fixture 621a4876 fetched; dual-build-cjs-loads and lean-entry-closure exit 3 until a full turbo build, then 0; type-check-debt run after the full build, exit 0. check-cli-command-ids exit 0; check-nul-bytes exit 0. Record: spec-seat-2/r2026-11-13/out/32838-gates-ran-f4ce7b50.list. CI check-runs on PR #33140: in_progress at report time.",
     "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
     "mcp_calls": "4 — reads only: issue_read x4 (card get, card comments, parent #32835 get, parent sub-issues); 0 write tools",
     "api_writes": "2 relay writes — pr_create objectstack-ai/objectstack#33140 (draft, assignee os-tesla) via fleet-write dispatch fw-20261113T165515Z-49cfcb; this os-dev-report comment via post-stamped. Plus git push (not REST).",
     "open_questions": [],
     "security_findings": "none",
     "out_of_scope_findings": [
      "carrier: #32840 · page-field-unprovisioned is also pushed by validate-sortable-fields.ts checkPageSortDeclaration (a page write returns it); #32840's catalog must set userTextParams there too · noted in PR #33140 Acceptance notes, not filed"
     ]
    }
  7. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibvfX5bawZKtfa6u7j9

    Landed · 2026-11-13T17:57Z

    Reading Value
    PR #33140 MERGED 2026-11-13T17:57Z as dd4ce50b, landing head 4605d6ef (ACCEPT 6860211519; seat review of record, no path-derived contract-review mandate)
    This card closed by Fixes #32838; 5 door-reaching ids carry a sentence; the ids the publish door never returns stay on the English message (named in the changeset and the PR's Acceptance notes, per #32835's Done-when alternative); the page-field-unprovisioned page-sort site is #32840's

    State: pm:dispatched removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:i18nThe customer's own language, across UI, metadata and notificationsdomain:specDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions